feat(hugr-llvm): Emit ipow #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
force-pushed
the
emit-ipow
branch
2 times, most recently
from
1b31c14 to
11fbfe4
Compare
mark-koch
approved these changes
Jan 7, 2025
| @@ -397,6 +460,9 @@ mod test { | |||
| #[case::iand("iand", 6, 15, 6)] | |||
| #[case::iand("iand", 15, 6, 6)] | |||
| #[case::iand("iand", 15, 15, 15)] | |||
| #[case::ipow("ipow", 2, 3, 8)] | |||
| #[case::ipow("ipow", 42, 1, 42)] | |||
| #[case::ipow("ipow", 42, 0, 1)] | |||
There was a problem hiding this comment.
Could you also add some similar tests to test_exec_signed_bin_op for negative bases?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
- Coverage 86.55% 86.52% -0.03%
==========================================
Files 194 194
Lines 35156 35202 +46
Branches 31969 32015 +46
==========================================
+ Hits 30430 30460 +30
Misses 2968 2968
- Partials 1758 1774 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jan 10, 2025
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
## 🤖 New release * `hugr`: 0.14.1 -> 0.14.2 (✓ API compatible changes) * `hugr-core`: 0.14.1 -> 0.14.2 (✓ API compatible changes) * `hugr-model`: 0.16.0 -> 0.17.0 (⚠️ API breaking changes) * `hugr-llvm`: 0.14.1 -> 0.14.2 (✓ API compatible changes) * `hugr-passes`: 0.14.1 -> 0.14.2 (✓ API compatible changes) * `hugr-cli`: 0.14.1 -> 0.14.2 (✓ API compatible changes) ###⚠️ `hugr-model` breaking changes ``` --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron Failed in: variant Term:Const in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:591 variant Term:ConstFunc in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:697 variant Term:ConstAdt in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:703 variant Term:Bytes in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:711 variant Term:BytesType in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:717 variant Term:Meta in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:720 variant Operation:Const in /tmp/.tmpszSQ4r/hugr/hugr-model/src/v0/mod.rs:409 --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_missing.ron Failed in: variant Term::Quote, previously in file /tmp/.tmp8fke0a/hugr-model/src/v0/mod.rs:565 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/struct_missing.ron Failed in: struct hugr_model::v0::MetaItem, previously in file /tmp/.tmp8fke0a/hugr-model/src/v0/mod.rs:500 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.14.2](hugr-v0.14.1...hugr-v0.14.2) - 2025-01-20 ### Bug Fixes - Three bugfixes in model import and export. (#1844) ### Documentation - Fix typo in `DataflowParent` doc (#1865) ### New Features - Add CallGraph struct, and dead-function-removal pass (#1796) - `Value::some`, `::none`, and `SumType::new_option` helpers (#1828) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) - Bytes literal in hugr-model. (#1845) - Improved representation for metadata in `hugr-model` (#1849) ### Testing - Add tests for constant value deserialization (#1822) </blockquote> ## `hugr-core` <blockquote> ## [0.14.2](hugr-core-v0.14.1...hugr-core-v0.14.2) - 2025-01-20 ### Bug Fixes - Three bugfixes in model import and export. (#1844) ### Documentation - Fix typo in `DataflowParent` doc (#1865) ### New Features - `Value::some`, `::none`, and `SumType::new_option` helpers (#1828) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) - Bytes literal in hugr-model. (#1845) - Improved representation for metadata in `hugr-model` (#1849) ### Testing - Add tests for constant value deserialization (#1822) </blockquote> ## `hugr-model` <blockquote> ## [0.17.0](hugr-model-v0.16.0...hugr-model-v0.17.0) - 2025-01-20 ### Bug Fixes - Three bugfixes in model import and export. (#1844) ### New Features - Constant values in `hugr-model` (#1838) - Bytes literal in hugr-model. (#1845) - Improved representation for metadata in `hugr-model` (#1849) </blockquote> ## `hugr-llvm` <blockquote> ## [0.14.2](hugr-llvm-v0.14.1...hugr-llvm-v0.14.2) - 2025-01-20 ### New Features - *(hugr-llvm)* Emit more int ops (#1835) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) ### Refactor - *(hugr-llvm)* [**breaking**] Optimise the llvm types used to represent hugr sums. (#1855) ### Testing - Fix failing inot test (#1841) </blockquote> ## `hugr-passes` <blockquote> ## [0.14.2](hugr-passes-v0.14.1...hugr-passes-v0.14.2) - 2025-01-20 ### New Features - Add CallGraph struct, and dead-function-removal pass (#1796) </blockquote> ## `hugr-cli` <blockquote> ## [0.14.1](hugr-cli-v0.14.0...hugr-cli-v0.14.1) - 2024-12-18 ### New Features - Print `hugr-cli`'s correct version when using '--version' (#1790) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.