Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixes to runner image update #1847

Merged
merged 10 commits into from
Jan 10, 2025
Merged

ci: fixes to runner image update #1847

merged 10 commits into from
Jan 10, 2025

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jan 8, 2025

Closes #1843

@ss2165 ss2165 changed the title wip fix llvm ci fix: llvm ci [wip] Jan 8, 2025
@hugrbot
Copy link
Collaborator

hugrbot commented Jan 8, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (b36d97d) to head (eb0c905).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         194      194           
  Lines       35156    35156           
  Branches    31969    31969           
=======================================
  Hits        30430    30430           
  Misses       2968     2968           
  Partials     1758     1758           
Flag Coverage Δ
python 92.31% <ø> (ø)
rust 85.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 changed the title fix: llvm ci [wip] ci: fixes to runner image update Jan 9, 2025
@ss2165 ss2165 marked this pull request as ready for review January 9, 2025 18:53
@ss2165 ss2165 requested a review from a team as a code owner January 9, 2025 18:53
@ss2165 ss2165 requested review from acl-cqc and doug-q and removed request for acl-cqc January 9, 2025 18:53
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly and semver checks are failing, I think both are ICE in nightly rust.

I am approving, because if you think merging despite these failures is the best course then I trust your judgement.

Two suggestions two use the variables you defined.

.github/workflows/ci-rs.yml Outdated Show resolved Hide resolved
.github/workflows/ci-rs.yml Outdated Show resolved Hide resolved
.github/workflows/ci-rs.yml Outdated Show resolved Hide resolved
@ss2165 ss2165 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 774a13e Jan 10, 2025
24 of 25 checks passed
@ss2165 ss2165 deleted the ci/llvm branch January 10, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: hugr-llvm tests are not consistently being run on merge requests touching hugr-llvm
3 participants