-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fixes to runner image update #1847
Conversation
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 194 194
Lines 35156 35156
Branches 31969 31969
=======================================
Hits 30430 30430
Misses 2968 2968
Partials 1758 1758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nightly and semver checks are failing, I think both are ICE in nightly rust.
I am approving, because if you think merging despite these failures is the best course then I trust your judgement.
Two suggestions two use the variables you defined.
Nightly is failing for what appears to be an unrelated rustc bug.has been fixed!apt-dependencies
appears to not be changing anything??? https://github.com/CQCL/hugr/actions/runs/12707081975/job/35421268084?pr=1847 ci: Semver checks are broken #1852Closes #1843