refactor(hugr-model)!: Reexport indexmap, bumpalo, and fxhash from hugr-model

[doug-q]

BREAKING CHANGE: read_from_slice now returns a new type ReadError.

[ss2165]

is it possible to export just the relevant types, perhaps using aliases? e.g. pub type Bump = bumpalo::Bump;

rather than re-exporting entire dependencies. Changes to these exports would be breaking in future.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (b38a2e8) to head (dda6f43).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1870   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files         194      194           
  Lines       35250    35250           
  Branches    32063    32063           
=======================================
  Hits        30501    30501           
  Misses       2973     2973           
  Partials     1776     1776           

Flag	Coverage Δ
python	92.34% <ø> (ø)
rust	85.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[doug-q]

is it possible to export just the relevant types, perhaps using aliases? e.g. pub type Bump = bumpalo::Bump;

rather than re-exporting entire dependencies. Changes to these exports would be breaking in future.

I don't see any reason to prefer an alias over a pub use?

That's what I started with, but I decided I would rather not make a decision on what are the relevant items.

To be clear before this PR breaking changes to these dependencies would already be breaking changes for hugr-model, but in a much more annoying way.

When there are not breaking changes this approach is the most useful for users, because we have not excluded something they need.

Happy to revise if you think it's much better. I would include:

• bumpalo::Bump as Bump
• bumpalo::collections::String as BumpString
• bumpalo::collections::Vec as BumpVec
• bumpalo::AllocErr as AllocErr
• indexmap::IndexMap
• fxhash::FxHashMap as FxHashMap

all in hugr_model::v0

[ss2165]

fair enough, I'd like to hear @zrho 's opinion on what are the useful set of things to make part of the interface

[zrho]

indexmap and fxhash are implementation details. bumpalo::Bump is the only part of bumpalo that is exposed in the API, so perhaps that one may be reexported. For the other stuff I don't really see a reason.