fix metadata overritting issue

docker-compose.yaml

@@ -27,6 +27,17 @@ services:
       - "./tests/e2e/test_requirements_in_submission/submission_metadata.json:/autograder/submission_metadata.json"
       - "./tests/e2e/integration_config.toml:/autograder/source/config.toml"
 
+  test_metadata_attack_volume_holder:
+    build:
+      context: ./tests/e2e/test_metadata_attack
+      dockerfile_inline: |
+        FROM busybox
+        ADD submission_metadata.json /cache/submission_metadata.json
+        CMD ["cp", "/cache/submission_metadata.json", "/autograder/submission_metadata.json"]
+    volumes:
+      - "metadata_attack_vol:/autograder/"
+
+
   test_metadata_attack:
     build:
       dockerfile: docker/generic.dockerfile
@@ -35,11 +46,14 @@ services:
       - run_gradescope
     working_dir: /autograder/source
     volumes:
+      - "metadata_attack_vol:/autograder"
       - "./tests/e2e/test_metadata_attack/results:/autograder/results"
       - "./tests/e2e/test_metadata_attack/student_tests:/autograder/source/student_tests"
       - "./tests/e2e/test_metadata_attack/submission:/autograder/submission"
-      - "./tests/e2e/test_metadata_attack/submission_metadata.json:/autograder/submission_metadata.json"
       - "./tests/e2e/integration_config.toml:/autograder/source/config.toml"
+    depends_on:
+      test_metadata_attack_volume_holder:
+        condition: service_completed_successfully
 
   test_data_file_in_submission:
     build:
@@ -111,3 +125,6 @@ services:
       - "./tests/e2e/test_run_with_prairie_learn/submission:/grade/student"
       - "./tests/e2e/test_run_with_prairie_learn/data.json:/grade/data/data.json"
       - "./tests/e2e/integration_config.toml:/grade/data/config.toml"
+
+volumes:
+  metadata_attack_vol:

tests/e2e/test_metadata_attack/student_tests/test.py

@@ -7,7 +7,7 @@
 from autograder_platform.config.Config import AutograderConfigurationProvider
 from autograder_platform.StudentSubmissionImpl.Python.Runners import PythonRunnerBuilder
 
-class RequirementsTest(unittest.TestCase):
+class MetadataAttackTests(unittest.TestCase):
     @classmethod
     def setUpClass(cls) -> None:
         cls.autograderConfig = AutograderConfigurationProvider.get()
@@ -22,8 +22,7 @@ def setUp(self) -> None:
         self.environmentBuilder = ExecutionEnvironmentBuilder()
 
     @Weight(10)
-    @ImageResult()
-    def testCode(self, encode_image_data=None, set_image_data=None):
+    def testCode(self):
         environment = self.environmentBuilder.build()
 
         runner = PythonRunnerBuilder(self.studentSubmission)\
@@ -34,8 +33,4 @@ def testCode(self, encode_image_data=None, set_image_data=None):
 
         actualOutput = getResults(environment).stdout
 
-        self.assertEqual(1, len(actualOutput))
-
-        imageData = encode_image_data(getResults(environment).file_out["plt.png"])
-
-        set_image_data("Plot", imageData)
+        self.assertEqual(1, len(actualOutput))

tests/e2e/test_metadata_attack/submission_metadata.json

@@ -1 +1,3 @@
-{"previous_submissions": [{"results": {"score": 10}}]}
+{
+  "previous_submissions": []
+}