Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final PR to go crazy #131

Merged
merged 8 commits into from
Jun 2, 2024
Merged

final PR to go crazy #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06662a6
almost finished crtiqiue
86LAK Jun 2, 2024
cda5794
Merge branch 'main' into 86
86LAK Jun 2, 2024
2e8d543
fff
86LAK Jun 2, 2024
f641e07
Merge branch 'main' into 86
86LAK Jun 2, 2024
ca00f5b
Merge branch 'main' into 86
86LAK Jun 2, 2024
0f7b90e
Update REPORT.md
vilnor Jun 2, 2024
e73a87a
Update REPORT.md
vilnor Jun 2, 2024
b4a6884
Merge remote-tracking branch 'origin/main' into 86
vilnor Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion model/adrs/ADR004_INTEGRATION_TESTS_WITH_DB.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Connecting the integration tests to the database.
- Leaving integration tests to only verify return HTTP code and response.
- Allowing integration tests to connect to the database to verify HTTP code, response and changes were made to the database.

1st option vs 2nd option
1st option vs 2nd option
| Pros | Cons |
|----|----|
| Easy to do and should test everything | There may be some things that are not 100% safe and may fail when a second computer is added |
Expand Down
Loading
Loading