Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Pack Hot Reload Key Remapping Support and Minor Changes #79

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

RavenholmZombie
Copy link
Contributor

Changes

  • Made it possible for players to remap the Sign Pack Hot Reload activator key.
  • Added chat messages for when the Entity Class Renderer has been toggled.

@CSX8600 CSX8600 self-requested a review February 27, 2024 16:20
Copy link
Owner

@CSX8600 CSX8600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • I see this is actually the intended fix for Hot Reload Key needs to be remappable #78 . Can we confirm that the issue with non-US QWERTY keyboards was indeed the lack of ']' and not the lack of 'F3'? If so, then I'd be alright with that part of the PR.
  • There's a ton of gradle changes in here I don't want to have made. I know at the time I think you were having problems with gradle but have since had it figured out. In that case, let's stick to the gradle setup we have and remove those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants