Merge in Badging prior release changes from Feature.nutmeg/badging #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becdavid
force-pushed
the
feature.nutmeg/badging
branch
from
e76798f to
f0983fa
Compare
becdavid
force-pushed
the
feature.nutmeg/badging
branch
3 times, most recently
from
f435384 to
29cfdad
Compare
We need to create a new Django app that is integrated into the platform since it uses base class CourseTab that is currently not setup to be used outside of the platform code. The code currently just makes the plugin setup but does not define calls to integrate badging-frontend code at the moment. This code update defines #4 from this page by adding new Django app to the platform codebase. https://openedx.atlassian.net/wiki/spaces/AC/pages/30965856/How+to+add+a+new+feature+to+LMS+or+Studio Added plugin for `course_badges` to openedx features. EW-405 This provides a plugin extension for badges where a learner can view their badge progress for within a course. Fix issue with courseware tab for `Badges` not being highlighted when selected. EW-405 Additional changes needed for Juniper release for badges tab. EW-525
This badging configuration model is to be used with assigning course events to BadgeClass models. When a chapter is complete we would award this configured BadgeClass model to the learner.
- Passed in user information to the lmsContext for badgesfrontend - Adjusted the footer to be max-width of 1920px - Updated badge_class.image to be full LMS Media path
…View` API endpoint. `Juniper` release. EW-526
…s a complete section. - Setup link for `View Badges` to go to the course badge progress page. - Adjusted styling for `View Badges` button. Todo: Eddie mentioned changing this to `fas-award` instead to avoid long text. - Moved handling of `award_section_badges` to handler.py file. - Cleaned up code.
…dge` from the course outline. Course outline page when no badge configuration for that section was not setup. EW-407
…se. EW-497 Following has changed: - Setup the Open edX BadgeClass `slug` to have default random value of 22 alphanumeric characters prefixed with `edx_` to help it standout from Badgr BadgeClass entityID which updates it automatically when the Badgr BadgeClass is created. This prevents us from having to manually create a BadgeClass with defined `slug` value in the Django admin page everytime a course is created. - Added `openedx__course` BadgeClass `issuing_component` to the `course_complete` code.
…r_block_event`. Missing method body. EW-526
…badge was earned. EW-526
…uer information. EW-242
… staff and instructor rights. EW-535
…EW-416 * Fixed issue with Progress Details showing incorrect issuer.
… be issued. EW-418 Slack: https://openedx.slack.com/archives/C4913NQCE/p1557848666015200 Previous Commit edx/edx-platform@25130ae https://openedx.atlassian.net/browse/LEARNER-4117 Peter Pinch (edX) mentions that there is a couple PRs in progress that will reverse the changes above and make it configurable.
…dgr. EW-418 Details: appsembler@dca736c
…-418 * Learner Profile > Accomplishments > Share * Certificate Share Screen > Add to Badgr
…orrect paths for MFE. EW-422
To fix issues when building out /dist for production there are additional *.min.{css|js} files needed.
…ect *.{css|js} files.
For `badges-frontend` MFE. EW-237
…rse complete event. EW-237 - Minor fix with the evidence url pulling SITE_NAME being site configuration to help with rendering of subsite specific certificate template.
… given subsite. EW-439 In a AWS (production) environment the `Evidence URL` kept showing the default site domain even for a subsite. This fixes the issue since `configuration_helpers.get_value` was always was checking for the `openedx.core.djangoapps.theming.helpers.py:get_current_site()` which was turning up Empty since production uses Celery task (`lms_high_mem_1`) to regenerate the certificate.
When serializing the `tabs` for field for `lms.djangoapps.courseware.tabs.CourseInfoTab` there was an error retrieving the `issue_badges` property for the `course` instance for `CourseBadgesTab` since the instance was a `CourseOverview` class. That field is found from the `CourseDescriptorWithMixins` class only for that course advanced field setting. This commit fixes that issue.
…frontend-app-learning`. Added in `course_home_api` endpoint for `course_metadata` for MFE course navigation elements even though this is not being used by the `frontend-app-learning` yet for this Juniper release.
…MFE Badges. EW-525
Previously we had made these changes, however, they are not needed anymore since the maple release handles this appropriately. The honor certificates will only be added to be ineligible if the DISABLE_HONOR_CERTIFICATES flag is enabled and the status of prior certificates awarded doesn't equal downloadable status meaning they have previously been awarded. Since we use honor certificates we'll never enable the DISABLE_HONOR_CERTIFICATES setting. a8caa55
The following changes were made: - Updated Course Tab for Badges - Recursively mark `badge_progress` when getting outline tree - Moved Badges plugin to fall inline with `lms.djangoapps.courseware.tabs`.
- Course `chapter` location is now show with name instead of UsageKey (e.g. "block-v1:").
- Fix `AttributeError: 'tuple' object has no attribute 'lower'` with `BadgeClass.get_badge_class`. - Fix `ValidationError` with `test_get_badge_class_data_validate`.
- Removed the dynamic tab for badges and made this hideable or moveable with `is_default`. Looking at `is_default` we may need to republish Advanced Settings in the course for the Badge tab to appear. https://openedx.atlassian.net/wiki/spaces/AC/pages/30965919/Adding+a+new+course+tab
This update sends back no badge progress to the frontend whenever the `Badge` tab is disabled for the course no matter if the learner has earned badge progress.
becdavid
force-pushed
the
feature.nutmeg/badging
branch
from
29cfdad to
1290b72
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.