Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied django-require package updates needed to successfully build the openedx Docker image for nutmeg. #229

Merged

Conversation

ztraboo
Copy link

@ztraboo ztraboo commented Mar 21, 2024

The original referenced repo https://github.com/edx/django-require?tab=readme-ov-file has been deprecated and moved to the openedx organization on Github.

Details concerning why we merge this commit are here.
https://discuss.openedx.org/t/please-update-your-git-urls-for-edx-platform-and-several-other-repos/12387

The tutor recommended patch updates for this did not work when we went to build out the openedx image. I was still receiving this git fetch error when pulling down the django-require repo even after the patch updates recommended by the community below.

image

Moving this to the openedx-dockerfile-post-python-requirements patch as well because it comes after the ./requirements/edx/base.txt call.

hooks.Filters.ENV_PATCHES.add_items([
   (
       "openedx-dockerfile-git-patches-default",
       """
# Fixing this `django-require` package to be from `openedx` org rather than `edx` org.
RUN git config url."https://github.com/openedx/django-require.git".insteadOf "https://github.com/edx/django-require.git"
"""
   ),
   (
       "openedx-dockerfile-post-python-requirements",
       """
# Make sure to install latest version of `openedx/django-require` for the platform to use. Uninstall existing version 1.0.12 first, then reinstall v2.0.0.
RUN pip uninstall -y django-require
RUN pip install -e git+https://github.com/openedx/[email protected]#egg=openedx-django-require==2.0.0
    ),
    ...
])

The original referenced repo https://github.com/edx/django-require?tab=readme-ov-file has been deprecated and moved to the `openedx` organization on Github.

Updates required based on comments here.
https://discuss.openedx.org/t/please-update-your-git-urls-for-edx-platform-and-several-other-repos/12387
@ztraboo ztraboo self-assigned this Mar 21, 2024
@ztraboo ztraboo added the bug label Mar 21, 2024
@ztraboo ztraboo merged commit afa3b1d into develop/nutmeg.master Mar 21, 2024
30 checks passed
@ztraboo
Copy link
Author

ztraboo commented Mar 21, 2024

Merged this without having the tests to pass. Needed this for building out the openedx image.

@ztraboo ztraboo added this to the cu-release/nutmeg.2 milestone Mar 21, 2024
ztraboo added a commit that referenced this pull request Mar 21, 2024
Reference this Nutmeg commit.
#229

The original referenced repo https://github.com/edx/django-require?tab=readme-ov-file has been deprecated and moved to the `openedx` organization on Github.

Updates required based on comments here.
https://discuss.openedx.org/t/please-update-your-git-urls-for-edx-platform-and-several-other-repos/12387
@ztraboo ztraboo changed the title Applied django-require package updates needed to successfully build the openedx Docker image. Applied django-require package updates needed to successfully build the openedx Docker image for nutmeg. Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant