Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Rework how we grab the mfe_config based on domain cha… #241

Merged

Conversation

becdavid
Copy link

@becdavid becdavid commented Jan 6, 2025

…nge.

With a S3/Cloudfront distribution fro the MFE frontends, we went with a https://{mfe}.{lms-domain} change making the MFE app a subdomain of the lms domain.

Example of additional BASE_URL needed within each MFE app configuraiton.

{
    "MFE_CONFIG": {
        "BASE_URL": "https://apps.{lms-domain}"
    },
    "MFE_CONFIG_ACCOUNT": {
        "BASE_URL": "https://account.{lms-domain}"
    },
    "MFE_CONFIG_COURSE-AUTHORING": {
        "BASE_URL": "https://course-authoring.{lms-domain}"
    },
    "MFE_CONFIG_GRADEBOOK": {
        "BASE_URL": "https://gradebook.{lms-domain}"
    },
    "MFE_CONFIG_LEARNING": {
        "BASE_URL": "https://learning.{lms-domain}"
    },
    "MFE_CONFIG_PROFILE": {
        "BASE_URL": "https://profile.{lms-domain}"
    }
}

…nge.

With a S3/Cloudfront distribution fro the MFE frontends, we went with a https://{mfe}.{lms-domain} change making the MFE app a subdomain of the lms domain.

Example of additional `BASE_URL` needed within each MFE app configuraiton.
```
{
    "MFE_CONFIG": {
        "BASE_URL": "https://apps.{lms-domain}"
    },
    "MFE_CONFIG_ACCOUNT": {
        "BASE_URL": "https://account.{lms-domain}"
    },
    "MFE_CONFIG_COURSE-AUTHORING": {
        "BASE_URL": "https://course-authoring.{lms-domain}"
    },
    "MFE_CONFIG_GRADEBOOK": {
        "BASE_URL": "https://gradebook.{lms-domain}"
    },
    "MFE_CONFIG_LEARNING": {
        "BASE_URL": "https://learning.{lms-domain}"
    },
    "MFE_CONFIG_PROFILE": {
        "BASE_URL": "https://profile.{lms-domain}"
    }
}
```
@becdavid becdavid force-pushed the feature.nutmeg/configuration-changes branch from 9cb3b9e to acbf5e4 Compare January 22, 2025 19:12
@becdavid becdavid merged commit f39e94a into develop/nutmeg.master Jan 23, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant