Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in badging frontend from Feature.nutmeg/badges #28

Open
wants to merge 11 commits into
base: develop/nutmeg.master
Choose a base branch
from

Conversation

becdavid
Copy link

No description provided.

@becdavid becdavid force-pushed the feature.nutmeg/badges branch 3 times, most recently from e1a0585 to b46ff84 Compare January 19, 2024 15:22
becdavid and others added 9 commits January 19, 2024 10:57
…to the new frontend structure.

Todo: This just renders the start of BadgeProgressTab at this URL, however, we still need to render out the progress details.

Also the Jest tests for `Test fetchBadgesProgressTab` still need to be worked out. The `Should fetch, normalize, and save metadata` is not working due to the `frontend-app-learning/src/course-home/data/__factories__/badgeProgressTabData.factory.js` Factory needing to be setup.

http://localhost:2000/course/{courseId}/badges/progress
Fixed issues with upgrading Paragon.

Todo: Need to build out EducateWorkforce theme from https://github.com/edx/brand-openedx instead of using https://github.com/edx/brand-edx.org going forward.
- Spoke with edX (@djoy) about upgrading Paragon to use latest version to support <DataTable /> component and he mentioned that there was minimal breaking changes.
https://openedx.slack.com/archives/C0EUBSV7D/p1619106947014800

- With Paragon upgrade it appears edX went to theming the frontend with what they call `brand` repo. Details here: https://open-edx-proposals.readthedocs.io/en/latest/oep-0048-brand-customization.html

- Needed to update the <Modal /> to <ModalDialog /> since it was being deprecated. Also there was a weird issue of when using a filter that the modal wouldn't load until I replaced this component out.

- Instructor is able to search for learner and filter by `Awarded`, `Not Awarded` badge assertions.
The following changes were made:
- Add unique key for BadgeProgressCard
- Return `badge_progress` from LMS API outline call and use it to display `Badge Progress` on outline page.
@becdavid becdavid force-pushed the feature.nutmeg/badges branch from b46ff84 to ee4cc44 Compare January 19, 2024 16:19
Updated this file to match what openedx had for nutmeg.master.
@becdavid becdavid linked an issue Jan 22, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Badging Frontend into Nutmeg Release
2 participants