Merge in badging frontend from Feature.nutmeg/badges #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becdavid
force-pushed
the
feature.nutmeg/badges
branch
3 times, most recently
from
e1a0585 to
b46ff84
Compare
…to the new frontend structure.
Todo: This just renders the start of BadgeProgressTab at this URL, however, we still need to render out the progress details.
Also the Jest tests for `Test fetchBadgesProgressTab` still need to be worked out. The `Should fetch, normalize, and save metadata` is not working due to the `frontend-app-learning/src/course-home/data/__factories__/badgeProgressTabData.factory.js` Factory needing to be setup.
http://localhost:2000/course/{courseId}/badges/progress
Fixed issues with upgrading Paragon. Todo: Need to build out EducateWorkforce theme from https://github.com/edx/brand-openedx instead of using https://github.com/edx/brand-edx.org going forward.
- Spoke with edX (@djoy) about upgrading Paragon to use latest version to support <DataTable /> component and he mentioned that there was minimal breaking changes. https://openedx.slack.com/archives/C0EUBSV7D/p1619106947014800 - With Paragon upgrade it appears edX went to theming the frontend with what they call `brand` repo. Details here: https://open-edx-proposals.readthedocs.io/en/latest/oep-0048-brand-customization.html - Needed to update the <Modal /> to <ModalDialog /> since it was being deprecated. Also there was a weird issue of when using a filter that the modal wouldn't load until I replaced this component out. - Instructor is able to search for learner and filter by `Awarded`, `Not Awarded` badge assertions.
The following changes were made: - Add unique key for BadgeProgressCard - Return `badge_progress` from LMS API outline call and use it to display `Badge Progress` on outline page.
becdavid
force-pushed
the
feature.nutmeg/badges
branch
from
b46ff84 to
ee4cc44
Compare
Updated this file to match what openedx had for nutmeg.master.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.