Upgrade @edx/brand to point to EducateWorkforce version for nutmeg release.
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reached out to support for this. It appears the page loading doesn't take changes in for the `brand-openedx` CSS changes, so we need to adjust the height manually. https://discuss.openedx.org/t/sticky-footer-mfe-learning-page-loading/12721
Verified that the instructional design team would like the the `subsection` sequences indented. This will allow for visual separation of the content and provide better nesting. I tried using bootstrap spacing https://getbootstrap.com/docs/4.3/utilities/spacing/ of `pl-5` but it was too far in for the indent and I needed to specify an exact value to align the checkmark progress with the title of the section name. Ref: #25
ztraboo
changed the title
@edx/brand to point to EducateWorkforce version.@edx/brand to point to EducateWorkforce version for nutmeg release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@edx/brandto point to EducateWorkforce branding