Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update iframe static stylesheet #35

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ztraboo
Copy link

@ztraboo ztraboo commented Sep 23, 2024

Resolution

EdX Changes Needed
openedx#1056

Error

about:srcdoc:1 Refused to apply style from 'https://apps.chooseaerospace.maple3.ew-dev.com/src/course-home/outline-tab/LmsHtmlFragment.css' because its MIME type ('application/xml') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

image

This error occurs because it cannot resolve the path. https://apps.chooseaerospace.maple3.ew-dev.com/ points to Cloudfront distribution (ID: E2GD04LD50Q7ZC, Domain Name: d2gft0eoukrnma.cloudfront.net) which has origin S3 bucket of educateworkforce-mfe-chooseaerospace-staging.s3.us-east-1.amazonaws.com. This S3 bucket has folders for each MFE (ie. /account/, /course-authoring/, /learning/, etc). and therefore needs those directories in the path to the CSS stylesheet that the app is trying to find (ie. https://apps.chooseaerospace.maple3.ew-dev.com/learning/.css)..)

The highlighted path would resolve to something like https://apps.chooseaerospace.maple3.ew-dev.com/src/course-home/outline-tab/LmsHtmlFragment.css which is not found in the S3 bucket directory. In fact the only CSS file found there is the npm build version https://educateworkforce-mfe-staging.s3.amazonaws.com/learning/app.6d7430f099cb09acda65.css

image

Need to consider how to rework the LmsHtmlFragment.jsx CSS include statement because it's being used in an <iframe> header link.

image

@ztraboo ztraboo self-assigned this Sep 23, 2024
@ztraboo ztraboo added the bug Something isn't working label Sep 23, 2024
@ztraboo ztraboo added this to the cu-release/maple.3 milestone Sep 23, 2024
@ztraboo ztraboo merged commit 8918114 into develop/maple.3 Sep 23, 2024
1 of 3 checks passed
@ztraboo
Copy link
Author

ztraboo commented Sep 23, 2024

Ignoring build issues for now with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants