Line chart improvements 2 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
des-des
requested changes
May 3, 2017
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| customWidth: props.currentGoal.ratings.length < 6 |
There was a problem hiding this comment.
Does this change? It does not look like it does..
If it does, maybe think about moving it into redux.
If it does not change, it should not be in the state. Either you can move this functionality into mapStateToProps or just make a helper here..
Might be easier if you told me why it is here..
There was a problem hiding this comment.
erm yeah, i don't know what i was doing 🙃 - have got rid of it now!
des-des
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements to the line chart!
animated arrow on preview version, should let user know that they can click to see more!
animation on detail version, scrolls to latest rating and automatically opens details of that rating (only takes effect when there are 6 or more ratings to see on one goal)
all related to #286
i think i might have done some really bad things here, sorry... 🙈