[Chore] #283 - 메소드 네이밍 변경

CaZaIt · Jun 19, 2023 · 2a67886 · 2a67886
1 parent 71d7fac
commit 2a67886
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/main/java/shop/cazait/domain/congestion/api/CongestionApiController.java b/src/main/java/shop/cazait/domain/congestion/api/CongestionApiController.java
@@ -15,7 +15,6 @@
 import shop.cazait.domain.congestion.dto.response.CongestionUpdateOutDTO;
 import shop.cazait.domain.congestion.exception.CongestionException;
 import shop.cazait.domain.congestion.service.CongestionService;
-import shop.cazait.domain.user.exception.UserException;
 import shop.cazait.global.common.dto.response.SuccessResponse;
 import shop.cazait.global.config.encrypt.JwtService;
 import shop.cazait.global.error.status.SuccessStatus;
@@ -41,7 +40,7 @@ public SuccessResponse<CongestionUpdateOutDTO> addCongestion(@PathVariable Long
             throws CongestionException {
 
         return new SuccessResponse<>(
-                SuccessStatus.CREATE_CONGESTION, congestionService.addAndUpdateCongestion(cafeId, congestionUpdateInDTO));
+                SuccessStatus.CREATE_CONGESTION, congestionService.createOrUpdateCongestion(cafeId, congestionUpdateInDTO));
 
     }
 

diff --git a/src/main/java/shop/cazait/domain/congestion/service/CongestionService.java b/src/main/java/shop/cazait/domain/congestion/service/CongestionService.java
@@ -1,10 +1,10 @@
 package shop.cazait.domain.congestion.service;
 
-import static shop.cazait.global.common.constant.Constant.NOT_EXIST_CONGESTION;
 import static shop.cazait.global.error.status.ErrorStatus.INVALID_CONGESTION;
 import static shop.cazait.global.error.status.ErrorStatus.NOT_EXIST_CAFE;
 
 import java.util.NoSuchElementException;
+import java.util.Objects;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -29,21 +29,18 @@ public class CongestionService {
     /**
      * 혼잡도 등록 및 수정
      */
-    public CongestionUpdateOutDTO addAndUpdateCongestion(Long cafeId, CongestionUpdateInDTO congestionUpdateInDTO) {
+    public CongestionUpdateOutDTO createOrUpdateCongestion(Long cafeId, CongestionUpdateInDTO congestionUpdateInDTO) {
 
         Cafe findCafe = getCafe(cafeId);
         Congestion findCongestion = findCafe.getCongestion();
         Congestion newCongestion = null;
 
         CongestionStatus congestionStatus = getCongestionStatus(congestionUpdateInDTO.getCongestionStatus());
 
-        if (findCongestion == NOT_EXIST_CONGESTION) {
+        if (Objects.isNull(findCongestion)) {
             newCongestion = addCongestion(findCafe, congestionStatus);
-        }
-
-        if (findCongestion != NOT_EXIST_CONGESTION) {
+        } else {
             newCongestion = updateCongestion(findCongestion, congestionStatus);
-
         }
 
         return CongestionUpdateOutDTO.of(newCongestion);