add validation to most apis, drop roles from edit form, add neighborh…

…ood input to all profile apis/forms

components/directory/CensusView.tsx

@@ -23,7 +23,7 @@ import { useProfile } from '../auth/useProfile'
 import { List } from '../core/List'
 import { useBackend } from '@/components/hooks/useBackend'
 import {
-  ProfileListParams,
+  ProfileListParamsType,
   ProfileListResponse,
   ProfileSort,
   ProfileListFragment,
@@ -48,7 +48,7 @@ export const CensusView = () => {
   const { user } = useProfile({ redirectTo: '/' })
   const { useGetPaginated } = useBackend()
 
-  const input = useMemo<ProfileListParams>(() => {
+  const input = useMemo<ProfileListParamsType>(() => {
     // Only search if there are at least 2 characters
     const searchQuery = searchValue.length >= 2 ? searchValue : ''
 

components/landing/NeighborhoodShowcase.tsx

@@ -2,7 +2,7 @@ import Link from 'next/link'
 import Image from 'next/image'
 import { useBackend } from '@/components/hooks/useBackend'
 import {
-  LocationListParams,
+  LocationListParamsType,
   LocationListResponse,
 } from '@/utils/types/location'
 import { getImageUrlByIpfsHash } from '@/lib/image'
@@ -15,7 +15,7 @@ export const NeighborhoodShowcase = () => {
   const { useGet } = useBackend()
   const { data } = useGet<LocationListResponse>('LOCATION_LIST', {
     sort: 'votesDesc',
-  } as LocationListParams)
+  } as LocationListParamsType)
 
   const locations = !data || 'error' in data ? [] : data.locations.slice(0, 4)
 

components/landing/NeighborhoodsTop6List.tsx

@@ -1,7 +1,7 @@
 import Link from 'next/link'
 import { useBackend } from '@/components/hooks/useBackend'
 import {
-  LocationListParams,
+  LocationListParamsType,
   LocationListResponse,
   LocationType,
 } from '@/utils/types/location'
@@ -17,7 +17,7 @@ export const NeighborhoodsTop6List = () => {
     'LOCATION_LIST',
     {
       locationType: LocationType.Neighborhood,
-    } as LocationListParams
+    } as LocationListParamsType
   )
   const { voteForLocation } = useLocationVote(refetchLocations)
 

components/neighborhoods/LocationsByVoteCount.tsx

@@ -3,7 +3,7 @@ import { useEffect, useState } from 'react'
 import InfiniteScroll from 'react-infinite-scroll-component'
 import {
   LocationFragment,
-  LocationListParams,
+  LocationListParamsType,
   LocationListResponse,
 } from '@/utils/types/location'
 import { useLocationVote } from '../hooks/useLocationVote'
@@ -21,7 +21,7 @@ export const LocationsByVoteCount = () => {
     mutate: refetchLocations,
   } = useGetPaginated<LocationListResponse>('LOCATION_LIST', {
     sort: 'votesDesc',
-  } as LocationListParams)
+  } as LocationListParamsType)
 
   const locations = data
     ? data.reduce(

components/neighborhoods/edit-location/BasicDetailStep.tsx

@@ -1,6 +1,9 @@
 import React, { useState } from 'react'
 import { useUpdateLocation } from '../useUpdateLocation'
-import { AddressFragmentType, LocationEditParams } from '@/utils/types/location'
+import {
+  AddressFragmentType,
+  LocationEditParamsType,
+} from '@/utils/types/location'
 import { useError } from '@/components/hooks/useError'
 import {
   MAX_LOCATION_BIO_LENGTH,
@@ -43,7 +46,7 @@ export const BasicDetailStep = ({
 
   const { showError } = useError()
 
-  const [locationInput, setLocationInput] = useState<LocationEditParams>({
+  const [locationInput, setLocationInput] = useState<LocationEditParamsType>({
     name: location.name,
     caretakerEmail: location.caretakerEmail,
     tagline: location.tagline,
@@ -57,7 +60,7 @@ export const BasicDetailStep = ({
 
   const handleOnChange = (
     e: React.ChangeEvent<HTMLInputElement>,
-    field: keyof LocationEditParams
+    field: keyof LocationEditParamsType
   ) => {
     const intFields = ['sleepCapacity', 'internetSpeedMbps']
 

components/neighborhoods/edit-location/DescriptionStep.tsx

@@ -12,7 +12,7 @@ import {
   REQUIRED_FIELD_ERROR,
 } from '@/utils/validate'
 import { useError } from '@/components/hooks/useError'
-import { LocationEditParams } from '@/utils/types/location'
+import { LocationEditParamsType } from '@/utils/types/location'
 
 export const DescriptionStep = ({
   name,
@@ -22,7 +22,7 @@ export const DescriptionStep = ({
   steps,
 }: StepProps) => {
   const { updateLocation } = useUpdateLocation(location.externId)
-  const [locationInput, setLocationInput] = useState<LocationEditParams>({
+  const [locationInput, setLocationInput] = useState<LocationEditParamsType>({
     description: location.description,
   })
 

components/neighborhoods/edit-location/OffersStep.tsx

@@ -2,7 +2,7 @@ import { useRouter } from 'next/router'
 import { useBackend } from '@/components/hooks/useBackend'
 import {
   OfferType,
-  OfferListParams,
+  OfferListParamsType,
   OfferListResponse,
   OfferNewParams,
   OfferNewResponse,
@@ -36,7 +36,7 @@ export const OffersStep = ({
     location ? 'OFFER_LIST' : null,
     {
       locationId: location.externId,
-    } as OfferListParams
+    } as OfferListParamsType
   )
   const offerList =
     !offersData || 'error' in offersData ? [] : offersData.offers

components/neighborhoods/edit-location/PhotoGalleryStep.tsx

@@ -3,7 +3,7 @@ import { useError } from '@/components/hooks/useError'
 import { useUpdateLocation } from '../useUpdateLocation'
 import { FileNameIpfsHashMap } from '@/lib/file-storage/types'
 import {
-  LocationEditParams,
+  LocationEditParamsType,
   LocationMediaCategory,
 } from '@/utils/types/location'
 import {
@@ -35,7 +35,7 @@ export const PhotoGalleryStep = ({
     [LocationMediaCategory.Features]: false,
   })
 
-  const [locationInput, setLocationInput] = useState<LocationEditParams>({
+  const [locationInput, setLocationInput] = useState<LocationEditParamsType>({
     bannerImageIpfsHash: location.bannerImageIpfsHash,
     mediaItems: location.mediaItems?.map((mediaItem) => ({
       ipfsHash: mediaItem?.ipfsHash,

components/neighborhoods/useUpdateLocation.ts

@@ -1,6 +1,6 @@
 import { useBackend } from '@/components/hooks/useBackend'
 import {
-  LocationEditParams,
+  LocationEditParamsType,
   LocationEditResponse,
 } from '@/utils/types/location'
 
@@ -10,7 +10,7 @@ export function useUpdateLocation(locationId: string | undefined) {
     locationId ? ['LOCATION', { externId: locationId }] : null
   )
 
-  const updateLocation = async (inputData: LocationEditParams = {}) => {
+  const updateLocation = async (inputData: LocationEditParamsType = {}) => {
     if (locationId) {
       const data = await mutateLocation(inputData)
 

components/neighborhoods/validations.ts

@@ -7,8 +7,8 @@ import {
   truthyString,
 } from '@/utils/validate'
 import { emptyEditorValue } from '../core/slate/slate-utils'
-import { OfferEditParams, OfferType } from '@/utils/types/offer'
-import { LocationEditParams } from '@/utils/types/location'
+import { OfferEditParamsType, OfferType } from '@/utils/types/offer'
+import { LocationEditParamsType } from '@/utils/types/location'
 
 export type ValidationType = 'missing' | 'invalid' | 'valid'
 
@@ -17,7 +17,7 @@ type ValidationResult = {
   valid: boolean
 }
 
-export const validateLocationInput = (values: LocationEditParams) => {
+export const validateLocationInput = (values: LocationEditParamsType) => {
   const {
     name,
     tagline,
@@ -45,7 +45,7 @@ export const validateLocationInput = (values: LocationEditParams) => {
 
 export const validateOfferInput = (
   type: OfferType,
-  newValues: OfferEditParams
+  newValues: OfferEditParamsType
 ) => {
   const invalid =
     !validateTitle(newValues.title).valid ||

components/offers/EditOfferPageView.tsx

@@ -5,7 +5,7 @@ import { useModal } from '../hooks/useModal'
 import { useNavigation } from '../hooks/useNavigation'
 import { useGetOffer } from './useGetOffer'
 import { useBackend } from '@/components/hooks/useBackend'
-import { OfferEditParams, OfferType } from '@/utils/types/offer'
+import { OfferEditParamsType, OfferType } from '@/utils/types/offer'
 import { SingleColumnLayout } from '../layouts/SingleColumnLayout'
 import { EditOfferView } from './EditOfferView'
 import { DiscardChangesModal } from '../core/DiscardChangesModal'
@@ -34,7 +34,7 @@ export const EditOfferPageView = () => {
 
   const [highlightErrors, setHighlightErrors] = useState(false)
   const [unsavedChanges, setUnsavedChanges] = useState(false)
-  const [newValues, setNewValues] = useState<OfferEditParams>({})
+  const [newValues, setNewValues] = useState<OfferEditParamsType>({})
 
   useEffect(() => {
     if (offer) {
@@ -78,7 +78,7 @@ export const EditOfferPageView = () => {
     }
   }
 
-  const handleOnEdit = (updateOfferInput: OfferEditParams) => {
+  const handleOnEdit = (updateOfferInput: OfferEditParamsType) => {
     setUnsavedChanges(true)
 
     setNewValues((prev) => ({

components/offers/EditOfferView.tsx

@@ -1,7 +1,7 @@
 import { useState } from 'react'
 import { useRouter } from 'next/router'
 import { useModal } from '../hooks/useModal'
-import { OfferEditParams, OfferFragment } from '@/utils/types/offer'
+import { OfferEditParamsType, OfferFragment } from '@/utils/types/offer'
 import styled from 'styled-components'
 import { ContentCard } from '../core/ContentCard'
 import { TitleCard } from '../core/TitleCard'
@@ -10,8 +10,8 @@ import { DiscardChangesModal } from '../core/DiscardChangesModal'
 
 interface EditOfferViewProps {
   offer: OfferFragment
-  updateOfferInput: OfferEditParams
-  onEdit: (updateOfferInput: OfferEditParams) => void
+  updateOfferInput: OfferEditParamsType
+  onEdit: (updateOfferInput: OfferEditParamsType) => void
   highlightErrors?: boolean
 }
 
@@ -25,7 +25,7 @@ export const EditOfferView = ({
   const { showModal } = useModal()
   const router = useRouter()
 
-  const handleEdit = (updateOfferInput: OfferEditParams) => {
+  const handleEdit = (updateOfferInput: OfferEditParamsType) => {
     setUnsavedChanges(true)
     onEdit(updateOfferInput)
   }

components/offers/OfferTabList.tsx

@@ -3,7 +3,7 @@ import { useProfile } from '../auth/useProfile'
 import { useBackend } from '@/components/hooks/useBackend'
 import {
   OfferFragment,
-  OfferListParams,
+  OfferListParamsType,
   OfferListResponse,
   OfferType,
 } from '@/utils/types/offer'
@@ -19,7 +19,7 @@ export const OfferTabList = ({ offerType }: { offerType?: OfferType }) => {
     useGetPaginated<OfferListResponse>('OFFER_LIST', {
       offerType: offerType ?? undefined,
       publiclyVisibleOnly: 'true',
-    } as OfferListParams)
+    } as OfferListParamsType)
 
   const offers = data
     ? data.reduce(

components/offers/edit-offer/EditOfferForm.tsx

@@ -1,7 +1,11 @@
 import React, { useState } from 'react'
 import { useRouter } from 'next/router'
 import { useModal } from '@/components/hooks/useModal'
-import { OfferEditParams, OfferFragment, OfferType } from '@/utils/types/offer'
+import {
+  OfferEditParamsType,
+  OfferFragment,
+  OfferType,
+} from '@/utils/types/offer'
 import {
   MAX_OFFER_TITLE_LENGTH,
   PHOTO_UPLOAD_INSTRUCTIONS,
@@ -32,8 +36,8 @@ import { useBackend } from '@/components/hooks/useBackend'
 
 interface EditOfferFormProps {
   offer: OfferFragment
-  updateOfferInput: OfferEditParams
-  onEdit: (updateOfferInput: OfferEditParams) => void
+  updateOfferInput: OfferEditParamsType
+  onEdit: (updateOfferInput: OfferEditParamsType) => void
   highlightErrors?: boolean
 }
 

components/offers/edit-offer/Pricing.tsx

@@ -1,5 +1,5 @@
 import { ChangeEvent } from 'react'
-import { OfferEditParams, OfferPriceInterval } from '@/utils/types/offer'
+import { OfferEditParamsType, OfferPriceInterval } from '@/utils/types/offer'
 import { REQUIRED_FIELD_ERROR } from '@/utils/validate'
 import styled from 'styled-components'
 import { SelectOption } from '@/components/hooks/useDropdownLogic'
@@ -30,11 +30,11 @@ const options = Object.values(OfferPriceInterval).map((interval) => ({
 }))
 
 interface PricingProps {
-  price?: OfferEditParams['price']
-  priceInterval?: OfferEditParams['priceInterval']
+  price?: OfferEditParamsType['price']
+  priceInterval?: OfferEditParamsType['priceInterval']
   onPriceChange?: (
-    price: OfferEditParams['price'],
-    priceInterval: OfferEditParams['priceInterval']
+    price: OfferEditParamsType['price'],
+    priceInterval: OfferEditParamsType['priceInterval']
   ) => void
   highlightErrors?: boolean
 }

components/profile/AboutInput.tsx

@@ -8,6 +8,7 @@ import { AvatarFragmentType } from '@/utils/types/profile'
 import { LocationAutocompleteInput } from '@/components/core/LocationAutocompleteInput'
 import { ADDRESS_ERROR } from '@/utils/validate'
 import { AddressFragmentType } from '@/utils/types/location'
+import { NeighborhoodSelect } from '@/components/profile/RegistrationForm'
 
 interface AboutInputProps {
   bio: string
@@ -16,6 +17,8 @@ interface AboutInputProps {
   onAddressChange: (location: AddressFragmentType) => void
   avatar?: AvatarFragmentType
   onAvatarChange?: (avatar: AvatarFragmentType | undefined) => void
+  neighborhoodExternId: string | null | undefined
+  onNeighborhoodChange: (n: string | null | undefined) => void
 }
 
 export const AboutInput = ({
@@ -25,6 +28,8 @@ export const AboutInput = ({
   onAddressChange,
   avatar,
   onAvatarChange,
+  neighborhoodExternId,
+  onNeighborhoodChange,
 }: AboutInputProps) => {
   const handleBioChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
     onBioChange(e.target.value)
@@ -51,6 +56,11 @@ export const AboutInput = ({
         error={!isValidAddress(address)}
         errorMessage={ADDRESS_ERROR}
       />
+      <NeighborhoodSelect
+        address={address}
+        neighborhoodExternId={neighborhoodExternId}
+        onNeighborhoodChange={onNeighborhoodChange}
+      />
     </SetupStepContainer>
   )
 }

components/profile/AvatarSetup.tsx

@@ -1,6 +1,6 @@
 import { useState } from 'react'
 import { Network, OwnedNft } from 'alchemy-sdk'
-import { ProfileEditParams } from '@/utils/types/profile'
+import { ProfileEditParamsType } from '@/utils/types/profile'
 import { getImageUrlFromNft } from '@/lib/image'
 import { FileNameIpfsHashMap } from '@/lib/file-storage/types'
 import { getImageUrlByIpfsHash } from '@/lib/image'
@@ -16,8 +16,10 @@ export type ExtendedOwnedNft = OwnedNft & {
 }
 
 interface AvatarSetupProps {
-  onNftSelected: (nft: ProfileEditParams['data']['avatar'] | undefined) => void
-  avatar?: ProfileEditParams['data']['avatar'] | undefined | null
+  onNftSelected: (
+    nft: ProfileEditParamsType['data']['avatar'] | undefined
+  ) => void
+  avatar?: ProfileEditParamsType['data']['avatar'] | undefined | null
 }
 
 export const AvatarSetup = ({ onNftSelected, avatar }: AvatarSetupProps) => {

components/profile/ContactInput.tsx

@@ -1,6 +1,6 @@
 import {
   ContactFieldType,
-  ContactFragment,
+  ContactFragmentType,
   MeFragment,
 } from '@/utils/types/profile'
 import { SetStateAction, useEffect } from 'react'
@@ -23,8 +23,8 @@ const contactOptions = Object.values(ContactFieldType).map(
 
 interface ContactInputProps {
   profile: MeFragment
-  contactList: ContactFragment[]
-  setContactList: (contactList: SetStateAction<ContactFragment[]>) => void
+  contactList: ContactFragmentType[]
+  setContactList: (contactList: SetStateAction<ContactFragmentType[]>) => void
 }
 
 export const ContactInput = ({