add diesel and users table #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmclark
force-pushed
the
maintenance/16-add-diesel
branch
from
7229543 to
28f690f
Compare
damon-myers
reviewed
Dec 9, 2018
src/db/messages/mod.rs
Outdated
| @@ -0,0 +1,11 @@ | |||
| use crate::db::models; | |||
| use actix_web::actix::*; | |||
There was a problem hiding this comment.
We do. actix imports the prelude which has the Message trait. We need actix_web for the actix_web::Error type.
There was a problem hiding this comment.
Hmmm, rather than use-ing the whole prelude of both, should we instead just use actix::Message and actix_web::Error? (super nit-picky for this stage in the development)
There was a problem hiding this comment.
Ok, I made it more explicit. I also updated a few other places I was importing actix or actix_web wildcards.
xmclark
commented
Dec 10, 2018
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds diesel ORM for interacting with sqlite database. It sets us up to interact with the database actor to query and command our data.
There is a directory structure that should help separate important concerns:
Handlers are functions that process messages. Messages are the messages important to the db actor. Models represent the data.
We can use sqlite for now during early development. This allows us to move a little faster.
This PR addresses some of the concerns in #16