Fix a few reported issues

Had a report of garrison in-progress missions causing issues.  Couldn't
repro but made some improvements that should help.

Made some changes to WagoAnalytics shim that will hopefully resolve the
errors there.

.pkgmeta

@@ -9,7 +9,7 @@ externals:
     url: https://github.com/tekkub/libdatabroker-1-1
     branch: master
   libs/WagoAnalytics:
-    url: https://github.com/wagoio/WagoAnalytics.git
+    url: https://github.com/wagoio/WagoAnalyticsShim.git
     branch: main
 
 enable-nolib-creation: no

CaerdonWardrobe.toc

@@ -5,7 +5,7 @@
 ## Title: Caerdon Wardrobe
 ## Notes: Shows BOE / BOA, openable, and unlearned pets, toys, mounts and wardrobe indicator on bank / bag / auction / merchant / guild bank / loot frame / loot roll / encounter journal slots
 ## Author: Caerdon
-## Version: v3.6.0
+## Version: v3.6.1
 ## SavedVariables: CaerdonWardrobeConfig
 ## OptionalDeps: WagoAnalytics, WoWUnit, AdiBags, AngrierWorldQuests, ArkInventory, Baganator, Bagnon, BaudBag, BetterBags, cargBags_Nivaya, Combuctor, ElvUI, Inventorian, KkthnxUI, LiteBag, Pawn, Skillet, Sorted, VenturePlan, WorldQuestsList, WorldQuestTracker, ZygorGuidesViewer
 

features/Mission.lua

@@ -83,27 +83,29 @@ function MissionMixin:OnGarrisonLandingScrollBoxRangeChanged(sortPending)
         local missionIndex = scrollBox:FindIndex(elementData)
 
         local index = 1;
-        for id, reward in pairs(elementData.rewards) do
-            local button = missionButton.Rewards[index];
-            if button.itemLink and button.itemID and button.itemID > 0 then
-                local options = {
-                    relativeFrame = button.Icon,
-                    statusOffsetX = 3,
-                    statusOffsetY = 3
-                }
-
-                local item = CaerdonItem:CreateFromItemLink(button.itemLink)
-                CaerdonWardrobe:UpdateButton(button, item, self, { 
-                    locationKey = format("garrisonlandingbutton-%d-%d", button.itemID, id)
-                }, options)
-            else
-                CaerdonWardrobe:ClearButton(button)
+        if elementData.rewards then
+            for id, reward in pairs(elementData.rewards) do
+                local button = missionButton.Rewards[index];
+                if button.itemLink and button.itemID and button.itemID > 0 then
+                    local options = {
+                        relativeFrame = button.Icon,
+                        statusOffsetX = 3,
+                        statusOffsetY = 3
+                    }
+
+                    local item = CaerdonItem:CreateFromItemLink(button.itemLink)
+                    CaerdonWardrobe:UpdateButton(button, item, self, { 
+                        locationKey = format("garrisonlandingbutton-%d-%d", button.itemID, id)
+                    }, options)
+                else
+                    CaerdonWardrobe:ClearButton(button)
+                end
+
+                index = index + 1
             end
-
-            index = index + 1
         end
 
-        for index = (#elementData.rewards + 1), #missionButton.Rewards do
+        for index = ((#elementData.rewards or 0) + 1), #missionButton.Rewards do
             CaerdonWardrobe:ClearButton(missionButton.Rewards[index])
         end
     end)