Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ref type #19

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Always ref type #19

merged 9 commits into from
Jan 29, 2024

Conversation

IsseW
Copy link
Contributor

@IsseW IsseW commented Jan 23, 2024

Fixes some padding issues, so this closes #17 .

Adds Ariadne error printing for the value conversion step.

Adds a marker for the FromBauble type that the type should always be parsed as a reference.

Copy link
Contributor

@MavethGH MavethGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few questions to make sure I understand the code properly, but other than that and one typo, everything looks perfect.

IsseW and others added 2 commits January 29, 2024 15:33
@IsseW IsseW merged commit 697ee23 into main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing use isn't padded by comments and whitespace
2 participants