Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of construct.Embedded to support python version >3.11 #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MohammedAdain
Copy link

The construct.Embedded feature has been removed in newer versions of the Construct library, as substructure fields are now automatically flattened in most cases. If you’re using a modern version of Construct, you can safely remove Embedded from your code, and the fields from the substructure should still be accessible as part of the parent structure.

@MohammedAdain
Copy link
Author

This Pull request helps fix #23. @wizche @Fitblip @smiba @ddworken please review and merge this PR.

@MohammedAdain
Copy link
Author

I built a new version of axeman locally and tested

axeman -l
axeman -v -u 'ct.googleapis.com/logs/us1/argon2024' -o logs/

and both of them seem to work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant