Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double negatives in the run tests shell script to make things clearer #260

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Jan 27, 2025

Should resolve #259

Moves X_ONLY to RUN_X and now checks:

if [ "${RUN_X}" = true ]; then
  cd "${BUILD_DIR}/test/x"
  ctest "${CTEST_ARGS}"
  cd -
fi 

Copy link
Contributor

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess I misunderstood but I thought you were going to change the actual argument too? Although I guess that'd beg the question of what the default options would be.

An alternative would be to split the test script into two- one for the unit tests and one for the integration tests?

@jatkinson1000 jatkinson1000 changed the base branch from 208_multi-gpu-build to main January 27, 2025 14:48
@jwallwork23
Copy link
Contributor

I think you might want to do an interactive rebase, dropping commits from #222.

@jatkinson1000
Copy link
Member Author

I was envisaging it going in after #222, but actually you are correct, could go in now at the expense of you perhaps needing to update 222.

Copy link
Contributor

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool, thanks!

@jatkinson1000 jatkinson1000 merged commit 03c5475 into main Jan 28, 2025
3 checks passed
@jatkinson1000 jatkinson1000 deleted the no-double-negatives branch January 28, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid double negatives in run_test_suite.sh command line options
2 participants