Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In permitted_attributes, switch from database column detection to Rails attributes detection. Addresses #838 #839

Merged
merged 5 commits into from
May 23, 2024
Merged

In permitted_attributes, switch from database column detection to Rails attributes detection. Addresses #838 #839

merged 5 commits into from
May 23, 2024

Commits on Dec 1, 2023

  1. In permitted_attributes, switch from database column detection to Rai… 

    …ls attributes detection. Fixes #838
    @kalsan
    kalsan authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    530a202 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Temporarly revert "In permitted_attributes, switch from database colu… 

    …mn detection to Rails attributes detection. Fixes #838"

This reverts commit 530a202.

Reason: Adjust tests to obtain a before and after picture
    @kalsan
    kalsan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1195d39 View commit details
    Browse the repository at this point in the history

  2. Switch AbilitySpec's User testcase to an actual database model NamedU… 

    …ser in order to include Rails' actual column loading behavior
    @kalsan
    kalsan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1edfe71 View commit details
    Browse the repository at this point in the history

  3. Demonstrate that the current implementation misses model attributes c… 

    …reated by Rails' "attribute" call
    @kalsan
    kalsan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4936716 View commit details
    Browse the repository at this point in the history

  4. Re-enable fix by reverting "Temporarly revert "In permitted_attribute… 

    …s, switch from database column detection to Rails attributes detection. Fixes #838""

This reverts commit 1195d39.
    @kalsan
    kalsan committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f68d752 View commit details
    Browse the repository at this point in the history