fix: improved error handling and optimized reactivity in Dashboard co… #1408
Conversation
…mponent Improvements & Fixes: ✅ Enhanced error handling for GraphQL queries & mutations: Displays more informative error messages for debugging. Ensures router.push(Path.Home) only triggers when necessary. ✅ Optimized useMemo usage for dashboardItems: Prevents unnecessary re-renders when data structure remains the same. ✅ Wrapped onUpdateChange & onDelete in try-catch blocks: Ensures UI does not break if an API call fails. ✅ Preserved all core logic – No functional changes, just refinements for stability.
WalkthroughThis pull request refines the Dashboard component by improving error handling and control flow. Error callbacks for queries and mutations now include actual error details in their messages. The redirect logic checks if the current path is not already the home route before navigating, and the layout update function now returns early when provided with null or empty values. The deletion functionality is wrapped in a try-catch block to capture and display specific error messages, and memoization is adjusted to depend on the latest fetched dashboard items. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant D as Dashboard Component
participant Q as Query Handler
participant M as Mutation/Deletion Handler
participant R as Router
U->>D: Load Dashboard Page
D->>Q: Fetch dashboard items
Q-->>D: Error response (with error message)
D->>D: Process error (display specific error detail)
D->>R: Verify current path and redirect if necessary
U->>D: Trigger layout update or delete action
D->>M: Call corresponding mutation/deletion (wrapped in try-catch)
M-->>D: Return success or error, handled in catch block
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I would like to request the merging of the pull request I submitted. All checks have been successfully validated, and there are no errors present. The changes have been reviewed and approved. Thank you for your attention to this matter. |
|
Hi @Vruddhi18 thanks for the contribution. @fredalai , @andreashimin could you guys check this PR ? |
There was a problem hiding this comment.
Hi @Vruddhi18,
Thank you so much for your contribution, and I apologize for the delayed response.
Since we already have error handling in place for our GraphQL API, I think we can remove the onError functions related to the dashboard mutation APIs to avoid showing duplicate error messages.
Let me know what you think! 😊
…mponent
Improvements & Fixes:
✅ Enhanced error handling for GraphQL queries & mutations:
✅ Displays more informative error messages for debugging. Ensures router.push(Path.Home) only triggers when necessary.
✅ Optimized useMemo usage for dashboard items:
✅ Prevents unnecessary re-renders when data structure remains the same.
✅ Wrapped onUpdateChange & onDelete in try-catch blocks: Ensures UI does not break if an API call fails.
✅ Preserved all core logic – No functional changes, just refinements for stability.
Summary by CodeRabbit
Bug Fixes
Refactor