Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine wren-ai-service logging and setups #486

Merged
merged 7 commits into from
Jul 8, 2024
Merged

refine wren-ai-service logging and setups #486

merged 7 commits into from
Jul 8, 2024

Conversation

cyyeh
Copy link
Member

@cyyeh cyyeh commented Jul 5, 2024 •
edited
Loading

  • added some missing logging info based on .env.ai, so in the future we can understand whether users fill in wrong information
  • fixed issues for the command make dev-up due to new version of wren-engine
  • add azure_deployment to azure_openai.py for embedder and provider implementation

@cyyeh cyyeh added the module/ai-service ai-service related label Jul 5, 2024
@cyyeh cyyeh requested a review from paopa July 5, 2024 18:24
@cyyeh cyyeh changed the title refine logging to providers minus update to wren-ai-service logging and setups Jul 6, 2024
@cyyeh cyyeh changed the title minus update to wren-ai-service logging and setups refine wren-ai-service logging and setups Jul 6, 2024
paopa
paopa reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions. others good to me.

wren-ai-service/src/providers/llm/azure_openai.py Show resolved Hide resolved
wren-ai-service/Makefile Show resolved Hide resolved
wren-ai-service/Makefile Outdated Show resolved Hide resolved
paopa
paopa approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paopa paopa merged commit 7047dce into main Jul 8, 2024
7 checks passed
@paopa paopa deleted the chore/ai-service/refine-logging branch July 8, 2024 08:35
onlyjackfrost pushed a commit that referenced this pull request Jul 11, 2024
@cyyeh @onlyjackfrost
refine wren-ai-service logging and setups (#486)
5afb4a8 
* refine logging

* use the latest tag

* fix setup instructions

* simplify dev process

* add azure_deployment

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paopa paopa paopa approved these changes

Assignees
No one assigned
Labels
module/ai-service ai-service related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyeh @paopa