Introduce the calculation for TO_MANY relationship #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieve54706
approved these changes
Jun 24, 2024
Comment on lines
-412
to
+446
| r#"SELECT "a"."c1", "a"."c2" FROM "default"."a""#), | ||
| r#"SELECT a.c1, a.c2 FROM wrenai."default".a"#), | ||
| ("select wrenai.default.a.c1, wrenai.default.a.c2 from wrenai.default.a where wrenai.default.a.c1 = 1", | ||
| r#"SELECT "a"."c1", "a"."c2" FROM "default"."a" WHERE ("a"."c1" = 1)"#), | ||
| r#"SELECT a.c1, a.c2 FROM wrenai."default".a WHERE (a.c1 = 1)"#), | ||
| ("select wrenai.default.a.c1 + 1 from wrenai.default.a", | ||
| r#"SELECT ("a"."c1" + 1) FROM "default"."a""#) | ||
| r#"SELECT (a.c1 + 1) FROM wrenai."default".a"#) |
There was a problem hiding this comment.
Why do we remove all double quotes?
There was a problem hiding this comment.
In DataFusion v39.0.0, only quote a identifier if it's a keyword.
apache/datafusion#10573
|
Thanks @grieve54706 |
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* upgrade to datafusio v39.0.0 * fix the 39.0.0 change * introduce to many calculation * add an example * stop panic and use DataFusionError instead * change the sqllogictests flow * stop panic and unwrap directly * fix count(*) aggregation for model and registered physical table * fmt and clippy * add one-one-many test case * fmt and clippy * fix test * update cargo lock * fmt and fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Known issue
WrenMDL#transform_sql