Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): implement the scope analysis to support the correlated subquery syntax #787

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Sep 11, 2024

Description

  • Implement the query scope analysis to solve the subquery and correlated subquery syntax
  • Fix the TPCH Q22 issue
  • Refactor the ModelAnalyzeRule flow

@goldmedal goldmedal changed the title fix(core) implement the scope analysis to support the correlated subquery syntax fix(core): implement the scope analysis to support the correlated subquery syntax Sep 11, 2024
@goldmedal goldmedal marked this pull request as ready for review September 11, 2024 07:23
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit 2ff1086 into Canner:main Sep 12, 2024
12 checks passed
@goldmedal goldmedal deleted the bugfix/support-scope-analysis branch September 12, 2024 05:00
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
…query syntax (#787)

* introduce scope analysis

* refactor the analysis rule

* expand view before analyze model

* implement the scope analysis and refactor model analysis

* enhance the doc

* cache the catalog_schema prefix

* add comment and missing rule

* rollback unused change

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants