fix(mssql): handle ibis error when sql with invalid syntax #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ibis handles this issue at ibis-project/ibis#10332. If we have time to wait for the ibis release, we can close this PR. |
Filed #840 to trace it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found the error
'NoneType' object has no attribute 'lower'.This issue arises because Ibis invokes the
lower()function on aNonevalue when using_get_schema_using_query().This PR addresses this by implementing error handling to capture this specific scenario and attempt to extract a more informative error message.
Moreover, we will continue following Ibis issue ibis-project/ibis#10331.