fix(core): disable pushdown filter to keep the casting for timestamp column #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, we will cast a timestamp column to a timestamp type because we must handle the
DATETIME
andTIMESTAMP
for the BigQuery. However,push_down_filter
will remove the casting because it can't differentiateDATETIME
andTIMESTAMP
in the DataFusion layer.see the unit test for the details.
If applying
push_down_filter
, the result will be as below. However, it will fail if出道時間
isDATETIME
in BigQuery