Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove unused properties field #941

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

goldmedal
Copy link
Contributor

Description

Remove the unused properties field from the MDL, Then, the user can apply the structure they want.

"properties": {
  "field": "test1",
  "nested": {
    "n1": "test1",
    "n2": "test2"
  }
}

Comment on lines +13 to +19
"properties": {
"field": "test1",
"nested": {
"n1": "test1",
"n2": "test2"
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a properties field to ensure users can create any property they want.

@goldmedal goldmedal marked this pull request as ready for review November 25, 2024 04:23
@grieve54706 grieve54706 added this to the 0.12.2 milestone Nov 25, 2024
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grieve54706 grieve54706 merged commit 1a62df3 into main Nov 25, 2024
9 checks passed
@grieve54706 grieve54706 deleted the chore/v2-remove-properties branch November 25, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants