(WIP) Cap for Windows #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove the prepareSidecars script from the beforeDevCommand.
|
@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Compiles and starts without errors 👀 |
…rev sync with upstream
Co-Authored-By: Brendan Allan <[email protected]>
Co-Authored-By: Brendan Allan <[email protected]>
|
Changes on macOS:
|
|
Merging while unfinished to avoid having a super large feature branch. Remaining stuff for windows support is in #108. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves (mostly) #108
Editor workingWindows-style window controls and minor UI patchesRunning the app on Windows:
Follow the Tauri prerequisites for Windows if you haven't set up Rust and Tauri on Windows yet.
Download the shared ffmpeg binary for Windows and rename it to
ffmpeg-x86_64-pc-windows-msvc.exe. Place it inside<Project root>/target/binaries/.BtbN ffmpeg releases.
Copy the DLLs below from the shared ffmpeg zip:
avutil,avformat,avcodec,avdevice,avfilterAnd paste them inside
<Project root>/target/debugYou should then be able to run the app in development.
If not, you might need to install ffmpeg using
vcpkg.Upcoming changes:
Missing:
no ffmpeg in the
prepareSidecars.jsscript for Windows. There should be one forx86_64-pc-windows-msvcandaarch64-pc-windows-msvcWe'll have to update scap in the future to use the latest windows and windows-capture crates.
Known issue:
[1018/212546.923:ERROR:window_impl.cc(121)] Failed to unregister class Chrome_WidgetWin_0. Error = 1411This error appears when the app exists on Windows. This is likely from within Tauri as mentioned by fabianlars on Discord and the issue on Github.