Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health and speed check (issue #73) #74

Closed
wants to merge 18 commits into from

Conversation

ItsEeleeya
Copy link
Contributor

@ItsEeleeya ItsEeleeya commented Aug 16, 2024

Solves #73

Implement a progress tracker for upload::upload_recording_asset

I've only got to test the tracker in a separate test progress with dummy data going to httpbin. This hasn't been tested with S3 yet.

For this to work, the file has to be sent in multipart chunks.
Only RecordingAssetType::CombinedSourcePlaylist is uploaded in chunks. It's currently set to 1MB chunks but we might need to change this.

On the frontend:

  • There's now popover for selecting the recording quality. It will show you which one is recommended for your connection. (Need further discussions.)
  • The titlebar now has a connection icon which will show you Cap's connection status.
    It pings the server to get a status back and also measure the latency on startup or every 20 seconds when the app is in focus or you click a refresh button.

Should the recommended resolution be determined after you upload your first Cap, or should it be done every time you launch or refresh the connection status?
Also, I'd appreciate any feedback on the design of the connection status popover and quality selection. Regarding the quality selection, this could be another select button above the AV device section, but this will require changing the window size and some margins.

The new progress and upload speed should appear when you stop the recording.

Copy link

vercel bot commented Aug 16, 2024

@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@ItsEeleeya
Copy link
Contributor Author

ItsEeleeya commented Aug 16, 2024

Here's a look at the new interfaces:



*Subject to change: MB/s to Mb/s

@ItsEeleeya ItsEeleeya marked this pull request as ready for review August 16, 2024 22:13
@ItsEeleeya ItsEeleeya closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant