-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health and speed check (issue #73) #74
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad progress event
@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #73
Implement a progress tracker for
upload::upload_recording_asset
I've only got to test the tracker in a separate test progress with dummy data going to httpbin. This hasn't been tested with S3 yet.
For this to work, the file has to be sent in multipart chunks.
Only
RecordingAssetType::CombinedSourcePlaylist
is uploaded in chunks. It's currently set to 1MB chunks but we might need to change this.On the frontend:
It will show you which one is recommended for your connection.(Need further discussions.)It pings the server to get a status back and also measure the latency on startup or every 20 seconds when the app is in focus or you click a refresh button.
Should the recommended resolution be determined after you upload your first Cap, or should it be done every time you launch or refresh the connection status?
Also, I'd appreciate any feedback on the design of the connection status popover and quality selection.
Regarding the quality selection, this could be another select button above the AV device section, but this will require changing the window size and some margins.The new progress and upload speed should appear when you stop the recording.