Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Date Design System #671

Open
wants to merge 7 commits into
base: release/1.1.0
Choose a base branch
from

Conversation

JadhavJeet
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (46f4a0c) to head (d84b6dc).
Report is 2 commits behind head on release/1.1.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/1.1.0      #671   +/-   ##
===============================================
  Coverage         100.00%   100.00%           
===============================================
  Files                 85        85           
  Lines               1579      1579           
  Branches             553       553           
===============================================
  Hits                1579      1579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

daniele-zurico
daniele-zurico previously approved these changes Jul 30, 2024
@JadhavJeet JadhavJeet force-pushed the feature/form-date-design-system branch from d84b6dc to 8a0c7a1 Compare August 20, 2024 11:43
@JadhavJeet JadhavJeet marked this pull request as ready for review October 29, 2024 10:07
@alexwbbr
Copy link
Collaborator

@JadhavJeet please can you add some documentation around the new class that get's added "dcx-form-date--filled" so users know it's there and when it gets applied

@JadhavJeet
Copy link
Collaborator Author

@JadhavJeet please can you add some documentation around the new class that get's added "dcx-form-date--filled" so users know it's there and when it gets applied

Done.

@JadhavJeet JadhavJeet changed the title adding embedded classname Form Date Design System Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants