Merge pull request #7 from CarbonPHP/feature/maximum-per-platform

Cap precision depending on maximum per platform
CarbonPHP · Dec 10, 2023 · a31d335 · a31d335
2 parents 49856fb + 1cb72be
commit a31d335
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
+.idea
 composer.lock
 composer.phar
 /vendor/

diff --git a/src/Carbon/Doctrine/CarbonTypeConverter.php b/src/Carbon/Doctrine/CarbonTypeConverter.php
@@ -8,6 +8,10 @@
 use Carbon\CarbonInterface;
 use DateTimeInterface;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Platforms\DB2Platform;
+use Doctrine\DBAL\Platforms\OraclePlatform;
+use Doctrine\DBAL\Platforms\SQLitePlatform;
+use Doctrine\DBAL\Platforms\SQLServerPlatform;
 use Doctrine\DBAL\Types\Exception\InvalidType;
 use Doctrine\DBAL\Types\Exception\ValueNotConvertible;
 use Exception;
@@ -35,7 +39,10 @@ protected function getCarbonClassName(): string
 
     public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
     {
-        $precision = $fieldDeclaration['precision'] ?? DateTimeDefaultPrecision::get();
+        $precision = min(
+            $fieldDeclaration['precision'] ?? DateTimeDefaultPrecision::get(),
+            $this->getMaximumPrecision($platform),
+        );
 
         $type = parent::getSQLDeclaration($fieldDeclaration, $platform);
 
@@ -104,4 +111,21 @@ private function doConvertToPHPValue(mixed $value)
 
         return $date;
     }
+
+    private function getMaximumPrecision(AbstractPlatform $platform): int
+    {
+        if ($platform instanceof DB2Platform) {
+            return 12;
+        }
+
+        if ($platform instanceof OraclePlatform) {
+            return 9;
+        }
+
+        if ($platform instanceof SQLServerPlatform || $platform instanceof SQLitePlatform) {
+            return 3;
+        }
+
+        return 6;
+    }
 }
diff --git a/tests/Doctrine/CarbonImmutableTypeTest.php b/tests/Doctrine/CarbonImmutableTypeTest.php
@@ -7,7 +7,10 @@
 use Carbon\CarbonImmutable;
 use Carbon\Doctrine\CarbonImmutableType;
 use DateTimeImmutable;
+use Doctrine\DBAL\Platforms\DB2Platform;
 use Doctrine\DBAL\Platforms\MySQLPlatform;
+use Doctrine\DBAL\Platforms\OraclePlatform;
+use Doctrine\DBAL\Platforms\SQLitePlatform;
 use Doctrine\DBAL\Types\Type;
 use PHPUnit\Framework\TestCase;
 
@@ -24,9 +27,7 @@ protected function setUp(): void
 
     public function testCarbonImmutableType(): void
     {
-        Type::addType('carbon_immutable', CarbonImmutableType::class);
-        /** @var CarbonImmutableType $type */
-        $type = Type::getType('carbon_immutable');
+        $type = self::getType();
         $platformClass = class_exists(MySQLPlatform::class)
             ? MySQLPlatform::class
             : \Doctrine\DBAL\Platforms\MySqlPlatform::class;
@@ -49,4 +50,37 @@ public function testCarbonImmutableType(): void
         self::assertInstanceOf(CarbonImmutable::class, $date);
         self::assertSame('2000-01-01 12:00:00 UTC', $date->format('Y-m-d H:i:s e'));
     }
+
+    public function testPrecisionPerPlatform(): void
+    {
+        $type = self::getType();
+
+        self::assertSame('DATETIME(3)', $type->getSQLDeclaration([
+            'precision' => 99,
+        ], new SQLitePlatform()));
+
+        self::assertSame('DATETIME(6)', $type->getSQLDeclaration([
+            'precision' => 99,
+        ], new MySQLPlatform()));
+
+        self::assertSame('TIMESTAMP(9)', $type->getSQLDeclaration([
+            'precision' => 99,
+        ], new OraclePlatform()));
+
+        self::assertSame('TIMESTAMP(12)', $type->getSQLDeclaration([
+            'precision' => 99,
+        ], new DB2Platform()));
+    }
+
+    private static function getType(): CarbonImmutableType
+    {
+        if (!Type::hasType('carbon_immutable')) {
+            Type::addType('carbon_immutable', CarbonImmutableType::class);
+        }
+
+        /** @var CarbonImmutableType $type */
+        $type = Type::getType('carbon_immutable');
+
+        return $type;
+    }
 }