Feature/sw 112 libcanard multi frame rx len fix cherry pick #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry picked commit : ensure payload_len is zeroed on start of a new multi-frame packet SW-112
Pradeep-Carbonix
approved these changes
Mar 5, 2024
|
@Pradeep-Carbonix verify the module tree too |
robertlong13
deleted the
feature/SW-112-libcanard-multi-frame-rx-len-fix-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified a critical bug fix in the libcanard submodule, as highlighted by Tridge. The fix addresses an issue that could potentially cause the watchdog to trigger on the peripheral. The key fix is available in this pull request: check decode in C++ wrappers and handle multiple frame starts by tridge.
However, we have decided not to cherry-pick the entire set of fixes at this time, as they can be incorporated in future upgrades. For the immediate resolution of the main bug, only one specific commit is required: e03112f.
Due to restrictions on modifying the Dronecan/libcanard repository within the Ardupilot project, we have created a fork of the libcanard repository and implemented the necessary changes there. Our forked branch can be found here: CarbonixUAV/libcanard - cx_dev.