AP_ICEngine: don't allow engine run with safety on #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing on PMU test unit: (Test by sending the crank signal from joystick) :
|
Jono453
approved these changes
Mar 19, 2024
loki077
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Logic looks correct to me. If the test results are confirmed by @LachlanConn then I am good.
| allow_throttle = ice->allow_throttle_disarmed(); | ||
| } | ||
| } | ||
| request_was_sent = (allow_throttle) ? send_target_values(new_throttle) : false; |
There was a problem hiding this comment.
why this is set to false on failure and not calling the function which will set the throttle 0 like in master.
As I am not sure if calling send_target_values(0) could have any other impact
if (allow_throttle) {
request_was_sent = send_target_values(new_throttle);
} else {
request_was_sent = send_target_values(0);
}
There was a problem hiding this comment.
Agreed,
Reverted it back to original, since we do not have more time to test it fully
Pradeep-Carbonix
force-pushed
the
feature/SW-122-engine-safety-check-cherry-pick
branch
from
28c56b6 to
f67aaee
Compare
loki077
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick source:
Cherry-pick was not sufficient, since the code has changed since 4.3.25. This code is tested after changes.