hwdef: CarbonixCubeOrange - added cx_built_in_test.lua

[loki077]

This commit introduces a Lua script, cx_built_in_test.lua, which serves as a Continuous Built-In Test (BIT) for Carbonix Aircrafts. The script checks multiple functionalities and provides the following features:

Firmware version check: The script ensures that the firmware version is at least 5.0.
ESC Status Check and Fault Detection: The script continuously checks the status of the ESC and detects any faults.
Aircraft type detection: The script automatically detects the type of aircraft (either Ottano or Volanti) based on the EFI type.
Pre-arm checks: The script performs several pre-arm checks, including checking the firmware version, initializing parameters, and checking the aircraft type.
During-arm checks: The script performs checks while the aircraft is armed, including checking ESC telemetry and VTOL failure checks.

This script is designed to enhance the safety and reliability of Carbonix Aircrafts by continuously monitoring their status and detecting any potential issues.

SW-61

[peterbarker]

Firmware version check: The script ensures that the firmware version is at least 5.0.

The script should be part of the firmware, in ROMFS. This check should be redundant at that point.

ESC Status Check and Fault Detection: The script continuously checks the status of the ESC and detects any faults.

This should be part of the existing ArduPilot pre-arm checks, rather than in a custom script.

Aircraft type detection: The script automatically detects the type of aircraft (either Ottano or Volanti) based on the EFI type.

Seems reasonable, allowing you to share the script across aircraft. But do consider separate-firmware-per-aircraft.

During-arm checks: The script performs checks while the aircraft is armed, including checking ESC telemetry and VTOL failure checks.

Again, ESC telemetry checks where the ESC is actively telling you that there's something wrong should be in the normal firmware. If you're adding heuristics (e.g. voltage-and-current-and-temperature is roughly the same for all ESCs), that's a good use of a script.

[peterbarker]

Probably also want to have some autotests to make sure this LUA script continues to work.

Some are trivial to test - set EFI_TYPE to 17 and make sure prearms fail with a specific error string.

[peterbarker]

Nice check. Result should be persistently failing to pre-arm until the problem is addressed. ArduPilot main firmware has trouble enforcing such a thing (we fly on all sorts of garbage), but for Ottano and Vollanti this would be a significant problem.

[peterbarker]

Not well named in that ArduPilot has "arming checks", which are often refered to as "arm checks". i.e. checks when you do when the user tries to arm the aircraft, not checks done while the aircraft is armed.

So perhaps "
while_armed_check_loop

[loki077]

The script should be part of the firmware, in ROMFS. This check should be redundant at that point.

This was done so legacy aircraft where we are not doing firmware update and just want the lua script would have helped, but now we have decide to upgrade all aircraft so it is good idea to remove that check.

[loki077]

This should be part of the existing ArduPilot pre-arm checks, rather than in a custom script.

agreed

[loki077]

Seems reasonable, allowing you to share the script across aircraft. But do consider separate-firmware-per-aircraft.

agreed

[ghost]

For now we will keep the pre Arm check of ESC telem in LUA and will wait for merging of TAKE_OFF_MIN RPM to be merged in Plane

[ghost]

This code was tested on dev/Volanti and V37 flights.,

[ghost]

@robertlong13