Fix servo assignments #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our original servo assignments, two of the CPN servos were set to act as servo 7. This clashed with the PWM outputs to the PLB (for which servo 7 and servo 14 are routed from the cube). To fix this, we meant to reassign Servo 7 to Servo 11. I accidentally reassigned Servo 6 instead of Servo 7 SW-181
ghost
approved these changes
May 8, 2024
ghost
approved these changes
May 8, 2024
ghost
merged commit
Pradeep-Carbonix
added a commit
that referenced
this pull request
Jun 20, 2024
Pradeep-Carbonix
added a commit
that referenced
this pull request
Jun 20, 2024
Servo6 function to 19
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our original servo assignments, two of the CPN servos were set to act
as servo 7. This clashed with the PWM outputs to the PLB (for which
servo 7 and servo 14 are routed from the cube). To fix this, we meant
to reassign Servo 7 to Servo 11.
I accidentally reassigned Servo 6 instead of Servo 7
SW-181
Associtated PR: https://github.com/CarbonixUAV/Carbo_Parameters/pull/25