Use defaults.parm for Volanti and Ottano #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
deleted the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
robertlong13
restored the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
robertlong13
force-pushed
the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
4 times, most recently
from
4a54e87 to
de6314d
Compare
robertlong13
force-pushed
the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
from
76062c6 to
e1449ea
Compare
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
loki077
reviewed
Jun 5, 2024
robertlong13
force-pushed
the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
3 times, most recently
from
9f17832 to
4666d6e
Compare
This fix scans all the include files in a hwdef, not just one on the first line. SW-159
This commit leads to zero changes to the output of hwdef.h for both CarbonixF405 and CarbonixL496. SW-159
Without this, Auto and Guided ignore terrain-frame commands. This does NOT force terrain following on for relative-frame commands. At the time of writing, Mission Planner only sends relative frame for Guided mode, but this parameter change means that I can fix that in the future without needing to update the firmware. SW-159
Changing TRIM_THROTTLE to 60% from 75% which is from the logs of Volanti to maintain TRIM_ARSPD_CM 21m/s. SW-159
Disable FFT as on lower Frequency it could create a major slew rate which could cause a crash. (Recommended by Tridge). Removing Harmonic Notch Filter as FFT is disabled. PID Pitch Rate D and I are reduce to compensate for removal of FFT. SW-159
As the new value is 100 which is the default. SW-159
The current compass priority is set as per GPS priority so left gps is Priority 1. SW-159
As current log size for an hour flight goes to 1GB so for a 2 hour flight we need atleast 2GB. Changing it to 5GB gives us enough space to not need to clear every flight once near full. SW-159
Loop Rate for Control in Cube set to 200Hz from 400Hz Results SW-171. This is done as bigger Aircraft such as Volanti and Ottano doesn't have response time for 400Hz change. Going to 200Hz hast advantage.. 1. Reducing Log size. 2. Freeing up CPU resources. SW-159
20m/s is the minimum airspeed demanded in automatic throttle modes. Should be 20% above stall speed which is 16.5m/s at 16kg MTOW. SW-159
As the default Range Finder has been moved to DroneCAN we don't need serial3 RangeFinder. SW-159
On boot the Safety state is ON "SAFE". This will be same to Ottano for consistency. SW-159
This fixes the servo assignment for Volant and Ottano Tail CPNs. SW-181 SW-159
FLTMODE1,11 # RTL FLTMODE3,10 # Auto FLTMODE4,19 # QLoiter FLTMODE5,7 # Cruise FLTMODE6 and 2 deleted as not used. SW-159
This helps us better understand/maintain items in the parameter files. SW-159
loki077
force-pushed
the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
from
df5c385 to
787c5e7
Compare
loki077
approved these changes
Jun 15, 2024
|
I have note reviewed Ottano default completely. |
|
I have tested the devid bit, but I'll check again now that we've made a few changes. |
|
@robertlong13 are you ok for me to merge this PR? |
Yes, we'll open another PR to fix any issues, if there are any, in the coming weeks. |
robertlong13
deleted the
feature/SW-159-use-defaults-parm-for-volanti-and-ottano
branch
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full overhaul of hwdefs for CPNs and autopilots. Leaning on include-structure where appropriate, and including defaults.parm for Volanti and Ottano (with a shared common param file for the parameters that should be shared between them).