cx_built_in_test: debounce audible warning for nil #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had a case where either rpm or servo out returned nil for a single loop for reasons that don't seem to be related to a telemetry dropout. To narrow down the cause, we have split the nil checks in two separate warnings. To prevent unnecessary concern, we are reducing the severity of the warning until one of these returns nil three loops in a row. Also fixed an issue where continuous nil returns would result in message spam. SW-219
robertlong13
force-pushed
the
feature/SW-219-v-37-pusher-message-during-forward-transition
branch
from
eff7965 to
2a11455
Compare
This shifts the failure check at top of the loop where Esc Telem previous time stamp, rpm and RC out are checked. Otherwise, the health would have cycled constantly between good and bad. Also drive-by cleanup of comments. SW-219
robertlong13
force-pushed
the
feature/SW-219-v-37-pusher-message-during-forward-transition
branch
from
0d038c6 to
def5980
Compare
loki077
approved these changes
Jun 4, 2024
|
Needs IronBird testing |
|
|
robertlong13
deleted the
feature/SW-219-v-37-pusher-message-during-forward-transition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a case where either rpm or servo out returned nil for a single loop for reasons that don't seem to be related to a telemetry dropout. To narrow down the cause, we have split the nil checks in two separate warnings. To prevent unnecessary concern, we are reducing the severity of the warning until one of these returns nil three loops in a row (or if 3+ ESCs do this all at once).
Also fixed an issue where continuous nil returns would result in message spam.
SW-219