Feature/sw 291 reverting the fft disable change 5.2 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
requested changes
Jul 26, 2024
libraries/AP_HAL_ChibiOS/hwdef/CubeOrange-Volanti/defaults.parm
Outdated
Show resolved
Hide resolved
Re Enable FFT as during testing we found tuning issues. Adding back Harmonic Notch Filter as FFT is enabled. PID Pitch Rate D and I are updated to support FFT. INS_FAST_SAMPLE,3 removed as this is defaulted in in cubeOrange to 7 and we want to use that. https://carbonix.atlassian.net/browse/SW-286 SW-291
This will increase descent time before it hits land final alt. https://carbonix.atlassian.net/browse/SW-285 SW-291
SW-291
loki077
force-pushed
the
feature/SW-291-reverting-the-fft-disable-change-5.2
branch
from
f6cedf0 to
003c4a1
Compare
|
@robertlong13 can you approve this too? |
robertlong13
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.