Tools: configure board-type in build-no-clean.sh #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pradeep-Carbonix
commented
Jul 31, 2024
•
Pradeep-Carbonix
commented
- Added 2 board checks : "CarbonixF405" and "CarbonixF405-no-crystal"
- Boards are configured before compilation : ./waf configure --board $BOARD
Pradeep-Carbonix
changed the title
|
The lack of configure call is intentional, so that a second build can be triggered without reconfiguring (this is done in the build-compare CI), letting it run much faster. This should probably be clarified better in a comment, or the build script should be refactored with an additional argument for whether to run a config first, but for now we'll leave it alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.