Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI : correct hirth EFI log messages #169

Conversation

Pradeep-Carbonix
Copy link
Contributor

  1. ECYL - state.cylinder_status.exhaust_gas_temperature2, format changed from B(uint8_t) to f(float)
  2. Sensor_ok - showing OK, when engine_temperature_sensor_status = 0

1. ECYL - state.cylinder_status.exhaust_gas_temperature2, format changed from B(uint8_t) to f(float)
2. Sensor_ok - showing OK, when engine_temperature_sensor_status = 0
@Pradeep-Carbonix Pradeep-Carbonix requested review from robertlong13 and a user August 1, 2024 02:38
@Pradeep-Carbonix Pradeep-Carbonix added the needs upstream Upstream PR against ArduPilot needed label Aug 7, 2024
Copy link
Contributor

@loki077 loki077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI @robertlong13

@loki077 loki077 merged commit 6aa7cc5 into CxPilot Sep 2, 2024
64 checks passed
@loki077 loki077 deleted the feature/SW-310-efi-cylinder-head-temperature-2-showing-constant-zero branch September 2, 2024 03:43
@robertlong13
Copy link
Collaborator

ArduPilot/ardupilot#28074
ArduPilot/ardupilot#28075

These two need to actually get downstreamed.

@robertlong13 robertlong13 removed the needs upstream Upstream PR against ArduPilot needed label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants