Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add param_check #180

Merged
merged 7 commits into from
Sep 16, 2024
Merged

CI: add param_check #180

merged 7 commits into from
Sep 16, 2024

Conversation

robertlong13
Copy link
Collaborator

SW-330

@robertlong13 robertlong13 force-pushed the feature/SW-330-ci-add-param-validation branch 3 times, most recently from eaa58ab to 09350c4 Compare September 2, 2024 07:12
@robertlong13
Copy link
Collaborator Author

This will (correctly) fail CI until it can be rebased on the BLHeli EXTLM change

@robertlong13 robertlong13 force-pushed the feature/SW-330-ci-add-param-validation branch from 09350c4 to cb8875b Compare September 2, 2024 23:22
@loki077
Copy link
Contributor

loki077 commented Sep 3, 2024

the Fix for below should be also part of this PR.

libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm: Failed
OUT_BLH_EXTLM not found in metadata
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm: Failed
OUT_BLH_EXTLM not found in metadata
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm: Failed
OUT_BLH_EXTLM not found in metadata
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm: Failed
OUT_BLH_EXTLM not found in metadata
libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm: Failed
OUT_BLH_EXTLM not found in metadata

@robertlong13
Copy link
Collaborator Author

the Fix for below should be also part of this PR.

libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M1.parm: Failed OUT_BLH_EXTLM not found in metadata libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M2.parm: Failed OUT_BLH_EXTLM not found in metadata libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M3.parm: Failed OUT_BLH_EXTLM not found in metadata libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M4.parm: Failed OUT_BLH_EXTLM not found in metadata libraries/AP_HAL_ChibiOS/hwdef/CarbonixCommon/cpn_params/Volanti/Volanti-M5.parm: Failed OUT_BLH_EXTLM not found in metadata

No, that's outside the scope of this PR. Once we merge the PR that adds BLHeli extended telemetry, I will rebase this PR on that, and it will pass. We won't merge this PR until then.

@robertlong13 robertlong13 force-pushed the feature/SW-330-ci-add-param-validation branch 2 times, most recently from 42eff9b to d55ad05 Compare September 4, 2024 04:59
@robertlong13 robertlong13 force-pushed the feature/SW-330-ci-add-param-validation branch from d55ad05 to 0e74068 Compare September 16, 2024 03:28
@robertlong13 robertlong13 merged commit 20420c6 into CxPilot-7 Sep 16, 2024
47 checks passed
@robertlong13 robertlong13 deleted the feature/SW-330-ci-add-param-validation branch September 16, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loki077 loki077 loki077 approved these changes

@Pradeep-Carbonix Pradeep-Carbonix Awaiting requested review from Pradeep-Carbonix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertlong13 @loki077