CommonDefaults: CPN OUT_BLH_MASK 1 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A value of 3 means "query OUT1 and OUT2 for telemetry". The new APD firmware sends telemetry always, without waiting for a query. This meant that both OUT1 and OUT2 were showing active telemetry, despite the fact that OUT2 is disabled in the configuration. This caused errant duplicate esc.Status packets that toggled between an index of `motor_index` and 1. This was causing the second ESCs telemetry to get clobbered with all the other ESCs data in the log. SW-259
loki077
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for this snuck its way into the 5.2 release prep PR (#164) and never made it into main.
SW-333