Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CxVersion: move include file to AP_FWVersion.h #196

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

robertlong13
Copy link
Collaborator

Previously LoggerMessageWriter wasn't correctly seeing that we had defined a custom fw string, so it was only logging our custom string message to the log, and leaving out the ArduPlane X.Y.Z string.

Relevant part of the code:

case Stage::FIRMWARE_STRING:
#ifdef AP_CUSTOM_FIRMWARE_STRING
// also log original firmware string if different
if (! _logger_backend->Write_MessageF("%s [%s]",
fwver.fw_string,
fwver.fw_string_original)) {
return; // call me again
}
#else
if (! _logger_backend->Write_Message(fwver.fw_string)) {
return; // call me again
}
#endif

Before:
CxPilot-7.0.0dev (F40D82EA)

After:
CxPilot-7.0.0dev (F40D82EA) [ArduPlane V4.5.6]"

Tested that plot.ardupilot.org now recognizes our logs as planes instead of quads.

Previously LoggerMessageWriter wasn't correctly seeing that we had
defined a custom fw string, so it was only logging our custom string
message to the log, and leaving out the ArduPlane X.Y.Z string.
@loki077 loki077 merged commit 88598ed into CxPilot-7 Sep 11, 2024
46 checks passed
@loki077 loki077 deleted the feature/SW-366-ardu-plane-text-missing-from-logs branch September 11, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants