Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwdef: CarbonixCommon: make servo bitmask common #204

Merged
merged 1 commit into from
Sep 19, 2024
Merged

hwdef: CarbonixCommon: make servo bitmask common #204

merged 1 commit into from
Sep 19, 2024

Conversation

robertlong13
Copy link
Collaborator

For now, there is no reason for these to be platform specific, and we
accidentally had Ottano be wrong.

@robertlong13
hwdef: CarbonixCommon: make servo bitmask common
86d69f9 
For now, there is no reason for these to be platform specific, and we
accidentally had Ottano be wrong.
Jono453
Jono453 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Jono453 Jono453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it again, no harm having servo9 on can bitmask as Volanti do need it post CASG as we saw with V94 and V95.

@robertlong13 robertlong13 merged commit 6f003ea into CxPilot-7 Sep 19, 2024
35 checks passed
@robertlong13 robertlong13 deleted the feature/SW-389-ottano-srv-bitmask-wrong branch September 19, 2024 10:20
@robertlong13 robertlong13 mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jono453 Jono453 Jono453 approved these changes

@LachlanConn LachlanConn LachlanConn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertlong13 @Jono453 @LachlanConn