AP_DroneCAN_DNA_Server : adding delay while logging 'CAND' #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
approved these changes
Sep 30, 2024
| @@ -439,6 +439,12 @@ void AP_DroneCAN_DNA_Server::handleNodeInfo(const CanardRxTransfer& transfer, co | |||
| if (transfer.source_node_id > MAX_NODE_ID) { | |||
| return; | |||
| } | |||
|
|
|||
| // Temporary fix to address the missing nodes - 15 and 24 | |||
There was a problem hiding this comment.
Suggested change
| // Temporary fix to address the missing nodes - 15 and 24 | |
| // Do not log until we are more than 30 seconds into boot | |
| // (temporary fix for lossy logging, causing some CAND messages to be lost) |
There was a problem hiding this comment.
additional comment is updated
There was a problem hiding this comment.
All nodes are now showing up :
This delay was added since the logging of CAND data for node-IDs 15 and 24 were always missing. More details of this problem can be found here : https://carbonix.atlassian.net/jira/software/c/projects/SW/boards/42/timeline?selectedIssue=SW-398
Pradeep-Carbonix
force-pushed
the
feature/SW-398-cand-missing-for-cpn-15-and-cpn-24
branch
from
452c561 to
cefaa35
Compare
Pradeep-Carbonix
deleted the
feature/SW-398-cand-missing-for-cpn-15-and-cpn-24
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delay was added since the logging of CAND data for node-IDs 15 and 24 were always missing. More details of this problem can be found here : https://carbonix.atlassian.net/jira/software/c/projects/SW/boards/42/timeline?selectedIssue=SW-398