Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2 Backport: hwdef: CubeOrange-Ottano: battery monitors #226

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

robertlong13
Copy link
Collaborator

SW-415

Copy link
Contributor

@Jono453 Jono453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Batt6 and Batt7 also need the ADC current and voltage scaling factors that were on batt2 and batt3 previously? I had to manually put them into O10 last minute during the engine test run today on 8/10/24 and worked after that.

@robertlong13 robertlong13 force-pushed the feature/SW-415-ottano-battery-layout branch from 0f90932 to f1ffe36 Compare October 9, 2024 03:10
Fix build failure for CubeOrange-Ottano by stripping comments before compilation to prevent parameter space issues.
@robertlong13 robertlong13 merged commit 69a7d60 into CxPilot-5.2 Oct 10, 2024
17 checks passed
@robertlong13 robertlong13 deleted the feature/SW-415-ottano-battery-layout branch October 10, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants