-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolving Servo Telemetry Clashes and making DroneCAN Servo compatible. #270
Fix: Resolving Servo Telemetry Clashes and making DroneCAN Servo compatible. #270
Conversation
I need a review from @LachlanConn @robertlong13 and @Jono453 on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the CPN changes from consideration here. We can keep the Cube changes.
Defaulting CPN params on an update is a pain that I'd like to avoid, and it buys us nothing. The Cube changes on their own pave the way for DroneCAN servos in Volanti, and no living Ottanos have servo CPNs anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I was about to mention that point where I will remove the Volanti CPN changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes done
dee1d2b
to
3994741
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy Ottano CPNs do not need the params changed as they have been replaced by CPCs. Instead, the parameters in each of the 6 x droneCAN servos will need to be updated to have their actuation_id match their new CUBE servo mappings
Looks good, once the CPN parts are removed I'll approve. |
3994741
to
9b0c0d8
Compare
9b0c0d8
to
7b3cbd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill update the dronecan servo QC page once this is ready as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
going to be tested by https://carbonix.atlassian.net/browse/FTE-22 |
Problem Statement:
In Ottano, the use of DroneCAN Servo causes telemetry log clashes due to indexing messages by Actuator ID. This occurs because multiple servos (aileron, elevator, rudder) share the same Actuator ID, resulting in overlapping logs that cannot distinguish between individual servo outputs.
Solution:
Split Servo Outputs For each Servo:
To address this, each servo output is now uniquely defined by function and position (right/left), ensuring no telemetry clash:
Broadcast Servo Outputs Across Both Buses:
The changes ensure all six servo outputs are broadcasted on both CAN buses, facilitating flexibility to relocate a servo between buses in the future. As in Volanti Right Wing and Left Tail are on one bus and in Ottano Right Wing and Right Tail are on same bus. Also, the impact on BUS bandwidth is not massive.
Scope and Implementation:
This change is specifically needed for Ottano and the upcoming Octtano platforms.
It has been ported to Volanti for future compatibility without impacting current aircraft functionality. This prepares Volanti for potential DroneCAN servo integrations.
Testing Requirements:
Testing is required on IronBird first, followed by validation on Ottano and Volanti.
Upgrade Impact:
When upgrading Ottano or Volanti, users must reset the Left Wing/Tail Parameters (CPN) to default after writing the updated firmware.