A0-4560: Changes in dag reconstruction to include parent round #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
Marcin-Radecki
had a problem deploying
to
Autobump version
GitHub Actions
Failure
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
changed the title
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
commented
Jan 14, 2025
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
commented
Jan 14, 2025
Marcin-Radecki
commented
Jan 14, 2025
Marcin-Radecki
commented
Jan 14, 2025
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
timorleph
approved these changes
Jan 15, 2025
Marcin-Radecki
temporarily deployed
to
Autobump version
GitHub Actions
Inactive
DamianStraszak
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up after 71f0314, that introduced notion of parent round in the Extender.
Here we modify
ControlHashaccordingly. Previously, it was usingNodeSubsetwhich was just aVec<bool>so a true/false whether given node index created a parent unit. Since we need now also the parent round, all code that reconstructs unit now have notion of a parent round.NodeSubsetis not removed as it is still used in the codebase.This change is actually a no-op to the algo - you can see in the PR removed code
round - 1to just parent round from unit store, however in practice it is stillround - 1as the changes to Creator are not done yet. This will be done in the next PR.